Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Galaxy Tools Merge results into a single file and we need an indicator of this in the UI #2381

Open
1 task
scottx611x opened this issue Nov 16, 2017 · 2 comments

Comments

@scottx611x
Copy link
Member

scottx611x commented Nov 16, 2017

  • Specific code commit: 7e8847f
  • Version of the web browser and OS: any
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance):
    test.stemcellcommons.org

UPDATE: Read this

Steps to reproduce

  1. Run an RNA-Seq (Se)/(PE) or Chip-Seq Analysis with more than one input file or input pair

Observed behavior

  • Analyses will run successfully, but a subset of the derived results are imported back into Refinery
  • From an RNA-Seq (SE) run with two input files. There should be 6 derived datafiles but there are only 4:
    screen shot 2017-11-16 at 2 38 18 pm

Expected behavior

  • For the proper amount of derived datafiles to be imported back into refinery

General Notes:

To Do:

  • Make sure that the proposed solution doesn't affect provvis rendering w/ subanlayses
@scottx611x scottx611x added this to the Release 1.6.2 milestone Nov 16, 2017
@scottx611x scottx611x self-assigned this Nov 16, 2017
@scottx611x scottx611x added this to To Do in Tool APIs via automation Nov 16, 2017
@scottx611x scottx611x moved this from To Do to Doing in Tool APIs Nov 17, 2017
@scottx611x
Copy link
Member Author

Looking into this issue deeper it seems that some tools, when given a dataset collection, will just provide a single output file with merged results from the N inputs. For example: featureCounts does this.

The proposed fix at the moment is to provide logic in _get_analysis_group_number so that said number, when displayed in the ui, would be updated to reflect which inputs have been used in the merged result.


Ex:

Run RNA Seq (SE) w/ 2 inputs:

Output Name Analysis Group Number
accepted_hits 0
accepted_hits 1
output 0 + 1
output summary 0 + 1

@scottx611x scottx611x changed the title Some Analysis runs with multiple input files/pairs produce a subset of expected outputs Some Galaxy Tools Merge results into a single file and we need an indicator of this in the UI Dec 21, 2017
@scottx611x scottx611x moved this from Doing to QC in Tool APIs Dec 21, 2017
@jkmarx jkmarx modified the milestones: Release 1.6.2, Next Jan 16, 2018
@scottx611x scottx611x modified the milestones: Next, Release 1.6.4 Apr 9, 2018
@scottx611x scottx611x moved this from QC to Doing in Tool APIs Apr 30, 2018
@jkmarx jkmarx modified the milestones: Release 1.6.4, Next May 11, 2018
@scottx611x
Copy link
Member Author

Another thought here is that these files will not be merged if we name the outputs appropriately (output summary for: input1.bam, output summary for: input2.bam) etc.

@jkmarx jkmarx removed this from the Next milestone Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Tool APIs
  
Doing
Development

No branches or pull requests

2 participants