-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scottx611x/revert to using workflow step annotations #2432
Closed
scottx611x
wants to merge
79
commits into
develop
from
scottx611x/revert_to_using_workflow_step_annotations
Closed
Scottx611x/revert to using workflow step annotations #2432
scottx611x
wants to merge
79
commits into
develop
from
scottx611x/revert_to_using_workflow_step_annotations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wnload_exposed_workflow_outputs
…wnload_exposed_workflow_outputs # Resolved Conflicts: # refinery/galaxy_connector/models.py # refinery/galaxy_connector/tests.py
…el' into scottx611x/only_download_exposed_workflow_outputs
…wnload_exposed_workflow_outputs
…_test' into scottx611x/only_download_exposed_workflow_outputs
This reverts commit 2903ebd.
…roper subset of Analysis results
…to_using_workflow_step_annotations
…to_using_workflow_step_annotations
Codecov Report
@@ Coverage Diff @@
## develop #2432 +/- ##
===========================================
+ Coverage 53% 55.42% +2.42%
===========================================
Files 407 407
Lines 26399 27878 +1479
Branches 1240 1240
===========================================
+ Hits 13993 15452 +1459
- Misses 12406 12426 +20
Continue to review full report at Codecov.
|
…to_using_workflow_step_annotations # Resolved Conflicts: # refinery/tool_manager/tests.py # refinery/tool_manager/views.py
…to_using_workflow_step_annotations
…to_using_workflow_step_annotations
…to_using_workflow_step_annotations
…to_using_workflow_step_annotations
4 tasks
…to_using_workflow_step_annotations
jkmarx
deleted the
scottx611x/revert_to_using_workflow_step_annotations
branch
August 30, 2018 14:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert back to using Galaxy Workflow step annotations to capture information about the outputs of the workflow to return to Refinery after a successful workflow run.
Fixes #2381
Towards #2294
TO-DO:
is_merged
logic/ better namingWorkflowTool._get_exposed_galaxy_datasets()