Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scottx611x/revert to using workflow step annotations #2432

Closed

Conversation

scottx611x
Copy link
Member

@scottx611x scottx611x commented Dec 14, 2017

Revert back to using Galaxy Workflow step annotations to capture information about the outputs of the workflow to return to Refinery after a successful workflow run.

Fixes #2381
Towards #2294


TO-DO:

  • is_merged logic/ better naming
  • update WorkflowTool._get_exposed_galaxy_datasets()
  • Remove checks for the asterisking workaround
  • Make sure test coverage is up to par
  • Update existing Workflow's step annotations
  • Test on AWS with our workflows
    • Make sure merged subanalysis number doesn't hinder provvis rendering
  • Update wiki page

…wnload_exposed_workflow_outputs

# Resolved Conflicts:
#	refinery/galaxy_connector/models.py
#	refinery/galaxy_connector/tests.py
…el' into scottx611x/only_download_exposed_workflow_outputs
…_test' into scottx611x/only_download_exposed_workflow_outputs
@scottx611x scottx611x added this to the Release 1.6.2 milestone Dec 14, 2017
@scottx611x scottx611x added this to To Do in Tool APIs via automation Dec 14, 2017
@codecov
Copy link

codecov bot commented Dec 21, 2017

Codecov Report

Merging #2432 into develop will increase coverage by 2.42%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2432      +/-   ##
===========================================
+ Coverage       53%   55.42%   +2.42%     
===========================================
  Files          407      407              
  Lines        26399    27878    +1479     
  Branches      1240     1240              
===========================================
+ Hits         13993    15452    +1459     
- Misses       12406    12426      +20
Impacted Files Coverage Δ
refinery/data_set_manager/isa_tab_parser.py 64.77% <100%> (+0.26%) ⬆️
refinery/data_set_manager/tests.py 99.76% <100%> (-0.01%) ⬇️
refinery/file_store/tasks.py 37.17% <0%> (-2.1%) ⬇️
refinery/file_store/models.py 62.45% <0%> (-1.86%) ⬇️
...ery/tool_manager/management/commands/load_tools.py 84.4% <0%> (-0.63%) ⬇️
refinery/tool_manager/utils.py 100% <0%> (ø) ⬆️
refinery/tool_manager/test_data/galaxy_mocks.py 100% <0%> (ø) ⬆️
refinery/factory_boy/django_model_factories.py 100% <0%> (ø) ⬆️
refinery/tool_manager/admin.py 100% <0%> (ø) ⬆️
refinery/tool_manager/tests.py 99.84% <0%> (+0.02%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf3dd3...ddfd4bd. Read the comment docs.

@scottx611x scottx611x moved this from To Do to QC in Tool APIs Dec 21, 2017
@scottx611x scottx611x modified the milestones: Release 1.6.3, Next Mar 16, 2018
@scottx611x scottx611x moved this from QC to Doing in Tool APIs Mar 29, 2018
@jkmarx jkmarx removed this from the Next milestone Apr 9, 2018
@scottx611x scottx611x closed this Jul 20, 2018
Tool APIs automation moved this from Doing to Done Jul 20, 2018
@jkmarx jkmarx deleted the scottx611x/revert_to_using_workflow_step_annotations branch August 30, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Tool APIs
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants