Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it less likely that users invite people to the wrong group #2906

Closed
2 tasks done
gmnelson opened this issue Jul 26, 2018 · 2 comments
Closed
2 tasks done

Make it less likely that users invite people to the wrong group #2906

gmnelson opened this issue Jul 26, 2018 · 2 comments
Assignees
Labels

Comments

@gmnelson
Copy link
Contributor

gmnelson commented Jul 26, 2018

  • Specific code commit: 30567f8
  • Version of the web browser and OS: macOS
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance): hsci.stemcellcommons.org

Steps to reproduce

Please list all the actions and the input data used:

  1. Click 'Invite user to group' from My Dashboard

Observed behavior

  • The current UI makes it somewhat likely that user could accidentally click the 'Invite user' icon for the wrong group
  • The resulting 'Invite New Member' modal does not tell you for which group you clicked
    image

Suggested solutions

  • Display the group name in the 'Invite New Member' modal (I might start with this, if it's easy to do)
  • Visually separate groups in Collaboration card (horizontal lines as in Data Sets, alternate shading)
    - [ ] Move Edit icons closer to Group names
@gmnelson gmnelson added the ui label Jul 26, 2018
@jkmarx jkmarx added this to the Release 1.6.6 milestone Jul 31, 2018
@jkmarx jkmarx added this to Planning/Not Started in JM Tasks 1.6.6 Jul 31, 2018
@jkmarx
Copy link
Member

jkmarx commented Aug 2, 2018

@gmnelson For task 3, did you mean swap the role and edit column OR should we look into a new layout?

@gmnelson
Copy link
Contributor Author

gmnelson commented Aug 7, 2018

@jkmarx For task 3, I think a more effective option might be to remove the Edit column and move the settings/invitation icons right next to the Group name (e.g. similar to the open folder icons for data sets).

That said, I'm not sure all three tasks are necessary to address this issue. You've already given users the ability to double-check their selection via task 1. Also, I've had no trouble correctly selecting member names within groups due to the horizontal lines -- if this is simple to add to the group level as well (i.e. task 2), I think we'd be in a good spot. Redesigning the layout (task 3), which I don't imagine is a quick project, is unnecessary at the moment, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
JM Tasks 1.6.6
Planning/Not Started
Development

No branches or pull requests

2 participants