Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group name to add modal. #2925

Merged
merged 2 commits into from Aug 2, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Aug 2, 2018

Ref #2906

screen shot 2018-08-02 at 7 54 04 am

@jkmarx jkmarx requested a review from mccalluc August 2, 2018 11:56
@jkmarx jkmarx self-assigned this Aug 2, 2018
@jkmarx jkmarx requested a review from gmnelson August 2, 2018 11:56
@jkmarx jkmarx added this to the Release 1.6.6 milestone Aug 2, 2018
@jkmarx
Copy link
Member Author

jkmarx commented Aug 2, 2018

@gmnelson Tagged you to view image.

@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #2925 into develop will decrease coverage by 0.96%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2925      +/-   ##
===========================================
- Coverage    60.34%   59.37%   -0.97%     
===========================================
  Files          435      435              
  Lines        28215    27291     -924     
  Branches      1283     1273      -10     
===========================================
- Hits         17025    16204     -821     
+ Misses       11190    11087     -103
Impacted Files Coverage Δ
...ce/js/commons/ctrls/group-member-add-modal-ctrl.js 56.75% <100%> (ø) ⬆️
refinery/core/views.py 42.36% <0%> (-5.24%) ⬇️
...ce/js/dashboard/controllers/data-sets-card-ctrl.js 66.34% <0%> (-4.45%) ⬇️
refinery/data_set_manager/api.py 95.37% <0%> (-2.69%) ⬇️
refinery/core/models.py 76.08% <0%> (-1.24%) ⬇️
refinery/core/tests.py 99.73% <0%> (-0.15%) ⬇️
...nery/ui/source/js/commons/services/data-sets-v2.js 100% <0%> (ø) ⬆️
...rce/js/dashboard/services/data-set-card-factory.js 100% <0%> (ø) ⬆️
refinery/core/test_views.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527cc10...7980cd7. Read the comment docs.

@jkmarx jkmarx merged commit a2c99a9 into develop Aug 2, 2018
@jkmarx jkmarx deleted the jkmarx/collaboration-card-ui-enhancement branch August 2, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants