Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error importing tabular metadata file - no samples displayed #2962

Closed
mccalluc opened this issue Aug 28, 2018 · 10 comments
Closed

Error importing tabular metadata file - no samples displayed #2962

mccalluc opened this issue Aug 28, 2018 · 10 comments

Comments

@mccalluc
Copy link
Member

mccalluc commented Aug 28, 2018

  • Specific code commit: f6b5665
  • Version of the web browser and OS: MacOS FF
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance): Production Test

Steps to reproduce

Please list all the actions and the input data used:

  1. Uploaded this CSV, accepted default column assignments, and associate a file for each row (Does the Data File Column refer to local files? --> Yes):
a,b,c
1,2,3
4,5,6
  • But Scott says non trivial files work too.
  • And I had thought I saw this when data was not associated, too.
  • It can be reproduced on beta: 30567f8

Observed behavior

Empty table, and no facets:
screen shot 2018-08-28 at 5 21 54 pm

In the console:

angular.js:14110 TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at angular.js:38
    at angular.js:30441
    at angular.js:17617
    at m.$digest (angular.js:17755)
    at m.$apply (angular.js:18021)
    at angular.js:18322
    at e (angular.js:6035)
    at angular.js:6314
(anonymous) @ angular.js:14110
3angular.js:14110 TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at angular.js:38
    at angular.js:30441
    at angular.js:17615
    at m.$digest (angular.js:17755)
    at m.$apply (angular.js:18021)
    at angular.js:18322
    at e (angular.js:6035)
    at angular.js:6314

Click to another tab and click back and it's there: Only a problem on initial load.

Assay/Files api returned duplicate attributes obj

@jkmarx
Copy link
Member

jkmarx commented Aug 29, 2018

Not an UI issue. Took a look at the api response and there's a duplicate attribute being returned. For some reason REFINERY_DATAFILE_s is being returned twice which is causing the circular import. Internal names should be unique and they are being used as keys.

@jkmarx
Copy link
Member

jkmarx commented Aug 29, 2018

  • check if reproduced locally
  • why a duplicate DATAFILE attribute is being associated (indexing issue?)

@jkmarx jkmarx self-assigned this Aug 29, 2018
@jkmarx jkmarx added the solr label Aug 29, 2018
@jkmarx jkmarx changed the title Empty table after upload, "TypeError: Converting circular structure to JSON" in console Assay/Files api returned duplicate attributes obj Aug 29, 2018
@hackdna
Copy link
Member

hackdna commented Sep 14, 2018

I just got this behavior in Vagrant environment using hg19-metadata-local.txt and a single uploaded data file.

@hackdna hackdna added this to the Next milestone Sep 14, 2018
@jkmarx
Copy link
Member

jkmarx commented Nov 1, 2018

@scottx611x

@scottx611x scottx611x self-assigned this Nov 1, 2018
@scottx611x scottx611x added this to Backlog in Scott O. Tasks via automation Nov 1, 2018
@scottx611x scottx611x modified the milestones: Next, Release 1.6.8 Nov 5, 2018
@hackdna
Copy link
Member

hackdna commented Dec 5, 2018

Still an issue in 42634ad (using hg19-metadata-local.txt and no data files).

@hackdna hackdna changed the title Assay/Files api returned duplicate attributes obj Error importing tabular metadata file - no samples displayed Dec 5, 2018
@scottx611x
Copy link
Member

@gmnelson Had a Tennen Lab member run into this same error again yesterday:

angular.js:14110 TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at angular.js:38
    at angular.js:30441
    at angular.js:17617
    at m.$digest (angular.js:17755)
    at m.$apply (angular.js:18021)
    at angular.js:18322
    at e (angular.js:6035)
    at angular.js:6314
(anonymous) @ angular.js:14110
3angular.js:14110 TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at angular.js:38
    at angular.js:30441
    at angular.js:17615
    at m.$digest (angular.js:17755)
    at m.$apply (angular.js:18021)
    at angular.js:18322
    at e (angular.js:6035)
    at angular.js:6314

@jkmarx
Copy link
Member

jkmarx commented Dec 12, 2018

@scottx611x Is the error (from Tennen lab) from a newly uploaded data set or a revised uploaded data set?

@scottx611x
Copy link
Member

@jkmarx Tennen Lab was for a revised, but the original issue is for a fresh upload. I think they're closely related.

@jkmarx jkmarx modified the milestones: Release 1.6.8, Next Feb 6, 2019
@hackdna hackdna removed this from the Next milestone Mar 13, 2019
@hackdna hackdna added this to the Release 1.6.9 milestone Mar 13, 2019
@jkmarx
Copy link
Member

jkmarx commented Apr 10, 2019

The above pull request #3196 should have resolved this issue. Has anyone encountered this bug since Feb? @hackdna @gmnelson If yes, please send me the data set you used. I'm unable to reproduce locally.

@gmnelson
Copy link
Contributor

@jkmarx have not seen this recently

@jkmarx jkmarx closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Scott O. Tasks
  
Backlog
Development

No branches or pull requests

5 participants