Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor global variables. #995

Open
flekschas opened this issue Apr 8, 2016 · 2 comments
Open

Refactor global variables. #995

flekschas opened this issue Apr 8, 2016 · 2 comments

Comments

@flekschas
Copy link
Member

Throughout older Angular JS code some global variables are used implicitly. This is an issue because the code runs magically while the developer doesn't know why.

Observed behavior

Node relationship relies on externalStudyUuid and externalAssayUuid. Both variables are members of window.

Expected behavior

Both variables should be part of the magic global variable called djangoApp which is automatically read by Angular.

This was both variables can be used via the import of settings. E.g. settings.djangoApp.externalStudyUuid is way more meaning full. In case something breaks the developer knows at least where to look.

@flekschas flekschas added this to the Next milestone Apr 8, 2016
@ngehlenborg ngehlenborg modified the milestone: Next Apr 12, 2016
@mccalluc
Copy link
Member

mccalluc commented Aug 5, 2016

#995

@jkmarx jkmarx self-assigned this Nov 23, 2016
@jkmarx jkmarx added this to the Release 1.6.1 milestone Oct 16, 2017
@ngehlenborg
Copy link
Contributor

Related to #2202.

@scottx611x scottx611x added this to Code in Technical Debt Oct 20, 2017
@jkmarx jkmarx modified the milestones: Release 1.6.1, Next, Release 1.6.2 Oct 30, 2017
@jkmarx jkmarx added this to Planning in JM Tasks 1.6.6 Nov 7, 2017
@jkmarx jkmarx moved this from Planning to Doing in JM Tasks 1.6.6 Nov 7, 2017
@jkmarx jkmarx moved this from Doing to Q/A in JM Tasks 1.6.6 Nov 27, 2017
@jkmarx jkmarx modified the milestones: Release 1.6.2, Next Jan 3, 2018
@jkmarx jkmarx moved this from Q/A to Planning/Not Started in JM Tasks 1.6.6 Jan 17, 2018
@jkmarx jkmarx removed this from the Next milestone Mar 20, 2018
@jkmarx jkmarx removed this from Planning/Not Started in JM Tasks 1.6.6 Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants