Jkmarx/refactor provvis code #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkmarx
commented
Nov 2, 2017
•
jkmarx
commented
- Resolves Refactor provvis global scope usage #1000
- Resolves If nothing else is needed, remove file-browser-1 code #2202
- Resolves "study_uuid: AND assay_uuid:" solr syntax error #2063
- Resolves Provenance Bug: URL fails to redirect #2285
- Ref Refactor global variables. #995
- Ref Remove unused templates #1993
- Remove backbone library
- Remove content.js, solr ui directory, and unused api services
- Add main ctrl using common services to populate solrResponse & analyses
- Break up provvis js render, motif, decl, and init into serves
- For now, fix reseting of graph when switching tabs (-to do)
- Add unit tests (-to do)
- Update js doc comments
…ry-platform into jkmarx/refactor-provvis-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.