Show filters only for logged in users. #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 33.95% (diff: 100%)@@ develop #1437 diff @@
==========================================
Files 328 328
Lines 22755 22755
Methods 0 0
Messages 0 0
Branches 1218 1218
==========================================
Hits 7727 7727
Misses 15028 15028
Partials 0 0
|
jkmarx
pushed a commit
that referenced
this pull request
Oct 4, 2016
* Fix #1312 * Enable share button only for data set owners. (#1434) * Jkmarx/sharing modal enhancements (#1436) * Enable share button only for data set owners. * Add helpful text of sharing modal. * Adjust text. * Group API returns group uuid. * Add link to groups in sharing modal. * Add group link to ui. * Add border. * Show filters only for logged in users. (#1437) * Show filters only for logged in users. * Fix spacing. * Mccalluc/remove sphinx (#1438) * Clear out docs directory * Remove sphinx dependencies Nothing else seems to have come in with these commits * Jkmarx/collaboration add member enhancements (#1440) * Add form validation. * Reformat modals to make consistent. * Fix styling. * Reformat code. * Add module unit test. * Add close x to each modal. * Add alerts modal. * Add comments. * Email invite unit test. * Add alert messages to add-group. * Add enter capability for enter. * Fix styling. * Rename method for clarity. * Add unit test. * Shorten time. * Add close to edit group. * Adjust layout and css. * Adjust css on group member edit. * Jkmarx/data import slug validation (#1441) * Remove duplicat file. * Fix div error. * Add error message for invalid slug. * Round percentages. (#1442) * Hackdna/workflow import (#1443) * Refactor get_workflows() * Refactor import_workflow() and check_workflow_inputs() * Code and string formatting * Fix a typo * Avoid relying on description of step inputs in workflow JSON for workflow import and execution * Remove unused get_step_inputs() and get_input_steps() * Improve code style and simplify logic * Remove unused function get_workflow_inputs() * Remove unnecessary conditional and variable * Remove unnecessary variable workflow_relationships, reformat code * Raise an exception instead of returning None * Improve code style * Remove unused code * Avoid redundant UUID generation * Fix log message handling * PEP8 formatting * Remove unused code * PEP8 fixes * Jkmarx/dataset2 new layout (#1413) * Remove tab buttons. * Remove other orange button references. * Refactor, remove style. * Remove style tag. * Remove unused states. * Remove hanging div. * Add conditional for dataset 2. * Move analysis tab to it's own partial. * Move details tab to own partial. * Move files to own partial. * Tab views. * Fix unit test. * Move display into own component. * Set default to files. * Add unit test. * Remove unused code. * Render pivotMatrixView call from within directive. * Unwrap provenance-view-tab watcher. * Add watchers to directive. * Remove console.log. * Correct description. * Update label. * New launch analysis component. * Add disable button conditionals. * Add unit test. * Add save directive. * Move save and reset buttons. * Add unit tests. * Move selected nodes text. * Move file display and config to new layout. * Add view and remove partial. * Add comments. * Adjust popover location. * Move save funtion to node_group partial. * Rename reset to better reflect purpose. * Rename partial. * Move analyses tab into own feature. * Column adjustments. * Parent controller. * Move file to view folder. * Keep only table view. * Fix typo in address. * Change buttons size. * Fix hidden popover. * Add css styling. * Fix padding. * Fix padding * Fix unit test. * Fix reset button. * Remove console. * Fix reset selection count. * Fix scoping issue. * Remove console.log * Fix run analysis ui. * Update color scheme. * Jkmarx/dataset2 igv (#1433) * Remove tab buttons. * Remove other orange button references. * Refactor, remove style. * Remove style tag. * Remove unused states. * Remove hanging div. * Add conditional for dataset 2. * Move analysis tab to it's own partial. * Move details tab to own partial. * Move files to own partial. * Tab views. * Fix unit test. * Move display into own component. * Set default to files. * Add unit test. * Remove unused code. * Render pivotMatrixView call from within directive. * Unwrap provenance-view-tab watcher. * Add watchers to directive. * Remove console.log. * Correct description. * Update label. * New launch analysis component. * Add disable button conditionals. * Add unit test. * Add save directive. * Move save and reset buttons. * Add unit tests. * Move selected nodes text. * Move file display and config to new layout. * Add view and remove partial. * Add comments. * Adjust popover location. * Move save funtion to node_group partial. * Rename reset to better reflect purpose. * Rename partial. * Move analyses tab into own feature. * Column adjustments. * Parent controller. * Move file to view folder. * Keep only table view. * Fix typo in address. * Change buttons size. * Fix hidden popover. * Add css styling. * Fix padding. * Fix padding * Fix unit test. * Fix reset button. * Remove console. * Fix reset selection count. * Fix scoping issue. * Remove console.log * Fix run analysis ui. * Update color scheme. * Add IGV directory. * Add directive. * Include partial in tab. * Add css. * Disable if no nodes are selected. * Add error handling and code to accomodate data set2. * Fix unit test and adjust css. * Add modal for launching igv * Add modal script. * Add visualization directory. * Add module. * Update partials. * Remove unused code. * Add script to partial and launch modal when igv selected. * Remove inline script. * Restructure modals to launch when visualization is selected. * Remove unused service. * Remove ununeccessary ctrl. * Clean up responsibilities. * Add conditions to launching igv. * Add factory. * Add comments. * Controller unit test. * Add visualization ctrl test. * Add directive unit tests. * Add factory unit test. * Comments. * Fix filter bug. * Fix description. * Remove duplicate id. * Add method comment. * Fix unit test. * Remove unused dependency. * Fix logger error message. * Clafity variable name. * Add log error message. * Edit error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1316