Scottx611x/tool manager updates #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1805 +/- ##
===========================================
+ Coverage 40.53% 40.75% +0.21%
===========================================
Files 391 391
Lines 25420 25536 +116
Branches 1271 1295 +24
===========================================
+ Hits 10304 10407 +103
- Misses 15116 15129 +13
Continue to review full report at Codecov.
|
jkmarx
reviewed
Jun 16, 2017
|
|
||
| from bioblend.galaxy.client import ConnectionError | ||
| from jsonschema import RefResolver, validate, ValidationError | ||
| from jsonschema import RefResolver, ValidationError, validate |
There was a problem hiding this comment.
is that from isort? caps before lowercase?
There was a problem hiding this comment.
Yes, isort puts classes first in alph. order
jkmarx
reviewed
Jun 16, 2017
refinery/tool_manager/tests.py
Outdated
|
|
||
| self.url_root = '/api/v2/tool_definitions/' | ||
| self.tools_url_root = '/api/v2/tools' |
jkmarx
reviewed
Jun 16, 2017
| validate_tool_annotation(workflow_annotation) | ||
| ) | ||
|
|
||
| def test_list_pair_list_workflow_tool_def_generation(self): |
There was a problem hiding this comment.
a lot of assetEquals, perhaps break into assert the different types separately.
jkmarx
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool&ToolDefinitionto dump json in rather than theast.literal_eval()approach from beforetool_manager.tests.pyhas a lengthy diff, but most of it is just moving existing members into places that make more sense