Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why we have a default haystack #1823

Merged
merged 3 commits into from Jun 26, 2017

Conversation

mccalluc
Copy link
Member

Fix #1822? I've looked at the git history a little bit, without getting a clear sense of how we got to the present state.

@mccalluc
Copy link
Member Author

  File "/home/travis/virtualenv/python2.7.13/lib/python2.7/site-packages/haystack/__init__.py", line 41, in <module>
    raise ImproperlyConfigured("The default alias '%s' must be included in the HAYSTACK_CONNECTIONS setting." % DEFAULT_ALIAS)
django.core.exceptions.ImproperlyConfigured: The default alias 'default' must be included in the HAYSTACK_CONNECTIONS setting.

http://django-haystack.readthedocs.io/en/v2.4.1/multiple_index.html

Haystack requires a "default", but there's no benefit to making it either of our two. I'll add that section back in, but explain why.

@mccalluc mccalluc requested a review from hackdna June 22, 2017 14:47
@mccalluc mccalluc changed the title We do not have a core to match this, so probably vestigial? Explain why we have a default haystack Jun 22, 2017
@codecov-io
Copy link

Codecov Report

Merging #1823 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1823   +/-   ##
========================================
  Coverage    41.04%   41.04%           
========================================
  Files          394      394           
  Lines        25758    25758           
  Branches      1278     1278           
========================================
  Hits         10572    10572           
  Misses       15186    15186

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4bcd8d...a4f3644. Read the comment docs.

@mccalluc mccalluc merged commit 8c95f5b into develop Jun 26, 2017
@mccalluc mccalluc deleted the mccalluc/what-breaks-if-we-remove-default-haystack branch June 26, 2017 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants