Mccalluc/add fields to datasetmanager index #1824
Conversation
|
(Tests still pass, which indicates that we need better coverage here.) |
…allowed, and method returns None, which doesn't feel like the right behavior?)
| name) | ||
|
|
||
| uniq_key = name + "_" + uuid + "_s" | ||
| generic_key = name + "_generic_s" |
There was a problem hiding this comment.
Adding "generic" fields to solr is the reason for this PR. Is this a reasonable approach?
There was a problem hiding this comment.
@mccalluc I wouldn't know myself without doing more research about solr.
I think @flekschas would have more of an idea than any other team member.
There was a problem hiding this comment.
Talked this over with Nils and he thinks its reasonable.
|
|
||
| test_file = StringIO() | ||
| test_file.write('Coffee is great.\n') | ||
| file_store_item = FileStoreItem.objects.create( |
There was a problem hiding this comment.
I've found that something in our codebase is still writing temp files to disk for FileStoreItems regardless of the class you use for the datafile param
We have a pre_delete signal for FileStoreItems that deletes these datafiles, so I've been doing this in my tests:
def tearDown(self):
FileStoreItem.objects.all().delete()
| name) | ||
|
|
||
| uniq_key = name + "_" + uuid + "_s" | ||
| generic_key = name + "_generic_s" |
There was a problem hiding this comment.
@mccalluc I wouldn't know myself without doing more research about solr.
I think @flekschas would have more of an idea than any other team member.
|
@mccalluc Also regarding the travis test failures I found overriding the |
…passes with no other changes, so not quite right
| from rest_framework.test import APIClient, APIRequestFactory, APITestCase | ||
|
|
||
| from .models import Assay, AttributeOrder, Study, Investigation, Node | ||
| from core.models import DataSet, ExtendedGroup, InvestigationLink |
There was a problem hiding this comment.
code style guide:
from __future__ import absolute_import
from .models import WaffleCone
from .forms import WaffleConeForm
from core.views import FoodMixin```
There was a problem hiding this comment.
isort wants to put relative imports at the end, which doesn't seem bad to me, but I'll look into overriding that: #1830.
Codecov Report
@@ Coverage Diff @@
## develop #1824 +/- ##
===========================================
+ Coverage 41.04% 41.21% +0.17%
===========================================
Files 394 394
Lines 25758 26360 +602
Branches 1278 1297 +19
===========================================
+ Hits 10572 10864 +292
- Misses 15186 15496 +310
Continue to review full report at Codecov.
|
Towards #1815: I want facets that will work across datasets. I'm not sure who has the most experience here, so listing everyone.
The test needs to be stronger, and after that the next step would be to use it in the UI.