Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more ajax error when not logged in (facets still empty, though) #1864

Merged
merged 2 commits into from Jul 6, 2017

Conversation

mccalluc
Copy link
Member

@mccalluc mccalluc commented Jul 5, 2017

No description provided.

@mccalluc mccalluc requested a review from scottx611x July 5, 2017 20:02
@codecov-io
Copy link

codecov-io commented Jul 6, 2017

Codecov Report

Merging #1864 into develop will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1864      +/-   ##
==========================================
+ Coverage    41.41%   41.5%   +0.09%     
==========================================
  Files          400     400              
  Lines        25974   26045      +71     
  Branches      1284    1303      +19     
==========================================
+ Hits         10756   10811      +55     
- Misses       15218   15234      +16
Impacted Files Coverage Δ
refinery/data_set_manager/utils.py 54.82% <100%> (+0.08%) ⬆️
refinery/user_files_manager/tests.py 100% <100%> (ø) ⬆️
refinery/user_files_manager/views.py 61.53% <0%> (-0.63%) ⬇️
.../tool-launch/services/file-relationship-service.js 77.29% <0%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cddb7e6...2187cc2. Read the comment docs.

@mccalluc mccalluc merged commit d407707 into develop Jul 6, 2017
@mccalluc mccalluc deleted the mccalluc/user-files-bugs branch July 6, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants