Mccalluc/unnecessary evals #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many of these we are taking a string from the url. There is a tight regex match on the url, but this is dangerous.
Codecov Report
@@ Coverage Diff @@
## develop #1935 +/- ##
===========================================
+ Coverage 41.94% 41.95% +0.01%
===========================================
Files 412 412
Lines 26771 26762 -9
Branches 1321 1321
===========================================
Hits 11229 11229
+ Misses 15542 15533 -9
Continue to review full report at Codecov.
|
scottx611x
approved these changes
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
globals()and**so we don't needeval()(This all makes sense to me, but I'm not sure what the test coverage is like: Wouldn't be unreasonable to ask me to check that before approval.)