Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mccalluc/user files sorting #1950

Merged
merged 12 commits into from
Aug 1, 2017
Merged

Mccalluc/user files sorting #1950

merged 12 commits into from
Aug 1, 2017

Commits on Jul 27, 2017

  1. Checkpoint: following the examples, but not working

    @mccalluc
    mccalluc committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    fbea323 View commit details
    Browse the repository at this point in the history

  2. I guess registration needs to happen before the promise returns?

    @mccalluc
    mccalluc committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    39532c8 View commit details
    Browse the repository at this point in the history

  3. Registration and sort callbacks get hit

    @mccalluc
    mccalluc committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    2e92250 View commit details
    Browse the repository at this point in the history

  4. sort asc and desc callbacks are being hit

    @mccalluc
    mccalluc committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    6ce475d View commit details
    Browse the repository at this point in the history

  5. If there is a solr error, I do not think downstream code can recover.… 

    … Instead of trapping and just logging, we will exit with a more helpful error
    @mccalluc
    mccalluc committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    206df2f View commit details
    Browse the repository at this point in the history

  6. Sorting triggers ajax

    @mccalluc
    mccalluc committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    2e085a7 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2017

  1. Extract data for multi-column sorts

    @mccalluc
    mccalluc committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    73fffea View commit details
    Browse the repository at this point in the history

  2. solr sorting sort-of works

    @mccalluc
    mccalluc committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    880dce2 View commit details
    Browse the repository at this point in the history

  3. Remove console statements, and a TODO

    @mccalluc
    mccalluc committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    a5c13d7 View commit details
    Browse the repository at this point in the history

  4. Fix test, and remove some logging

    @mccalluc
    mccalluc committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    d319c64 View commit details
    Browse the repository at this point in the history

  5. correct construction of error strings

    @mccalluc
    mccalluc committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    32235ef View commit details
    Browse the repository at this point in the history

  6. unused constants

    @mccalluc
    mccalluc committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    d6f0259 View commit details
    Browse the repository at this point in the history