Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user/files -> files; Not sure about csv #2007

Merged
merged 1 commit into from Aug 18, 2017

Conversation

mccalluc
Copy link
Member

fix #2001

@codecov-io
Copy link

Codecov Report

Merging #2007 into develop will not change coverage.
The diff coverage is 42.85%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2007   +/-   ##
========================================
  Coverage    44.12%   44.12%           
========================================
  Files          415      415           
  Lines        27575    27575           
  Branches      1322     1322           
========================================
  Hits         12168    12168           
  Misses       15407    15407
Impacted Files Coverage Δ
.../source/js/user-file-browser/services/user-file.js 65% <ø> (ø) ⬆️
...le-browser/ctrls/user-file-browser-filters-ctrl.js 12.5% <0%> (ø) ⬆️
...file-browser/ctrls/user-file-browser-files-ctrl.js 11.76% <0%> (ø) ⬆️
refinery/user_files_manager/tests.py 100% <100%> (ø) ⬆️
refinery/user_files_manager/urls.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 256e504...afe638a. Read the comment docs.

@mccalluc
Copy link
Member Author

@scottx611x : Could you review this?
@ngehlenborg : Is /files_download ok for the CSV? Or suggest something you prefer: I don't think the whole team needs to be looped into this discussion.

@ngehlenborg
Copy link
Contributor

What about .../files?download=csv? Could easily be extended to .../files?download=xls etc.

Note our naming convention for API endpoints: https://github.com/refinery-platform/refinery-platform/wiki/coding-style-guide#rest-api

@mccalluc
Copy link
Member Author

Sure: since that's more than a routing change, I don't want to let that block this bit, but I've filed #2013.

@mccalluc mccalluc merged commit c2e7c2d into develop Aug 18, 2017
@mccalluc mccalluc deleted the mccalluc/user-files-just-files branch August 18, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simpler url: "user/files" should just be "files"
4 participants