-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused templates #2017
Remove unused templates #2017
Conversation
…is directory is not needed.
@mccalluc The isa-tab-import.html template and metadata-table-import.html template were replaced by the angular states (data-set-import/state) The import template is still used as it hooks in the the above states. Where are these templates being references? |
Maybe these referencers are themselves unused? Or they should be? |
$ git grep isa-tab-import.html Otherwise, I don't believe |
Endpoints which are being hit by the current data-set-import View methods are being used by the current data-set-import module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refinery/templates/data_set_manager folder should be also removed if it's empty
Replaced by #2059 |
Fix #1993?
@jkmarx : Looking at this, I think each of these files is still referenced... Do you remember what you meant in saying that the imports could be removed?