Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused templates #2017

Closed

Conversation

mccalluc
Copy link
Member

@mccalluc mccalluc commented Aug 18, 2017

Fix #1993?

@jkmarx : Looking at this, I think each of these files is still referenced... Do you remember what you meant in saying that the imports could be removed?

@mccalluc mccalluc requested a review from jkmarx August 21, 2017 12:58
@jkmarx
Copy link
Member

jkmarx commented Aug 21, 2017

@mccalluc The isa-tab-import.html template and metadata-table-import.html template were replaced by the angular states (data-set-import/state) The import template is still used as it hooks in the the above states.

Where are these templates being references?

@mccalluc
Copy link
Member Author

@jkmarx:

$ git grep isa-tab-import.html
refinery/data_set_manager/views.py:    template_name = 'data_set_manager/isa-tab-import.html'
refinery/ui/source/js/data-set-import/directives/isa-tab-import.js:      return $window.getStaticUrl('partials/data-set-import/partials/isa-tab-import.html');
refinery/ui/source/js/data-set-import/state.js:          return window.getStaticUrl('partials/data-set-import/views/isa-tab-import.html');
refinery/ui/source/js/data-set-import/state.spec.js:      mockTemplate(window.getStaticUrl('partials/data-set-import/views/isa-tab-import.html'));

$ git grep metadata-table-import.html
refinery/data_set_manager/views.py:    template_name = 'data_set_manager/metadata-table-import.html'

Maybe these referencers are themselves unused? Or they should be?

@jkmarx
Copy link
Member

jkmarx commented Aug 23, 2017

$ git grep isa-tab-import.html
The bottom three refer to the angular partial not the template.

Otherwise, I don't believe those views and templates are being used (recommend you confirm). You can check the current import pages views are the angular partials. I believe Fritz updated them a year or so back

@jkmarx
Copy link
Member

jkmarx commented Aug 23, 2017

 checkFilesUrl: '/data_set_manager/import/check_files/',
      isaTabImportUrl: '/data_set_manager/import/isa-tab-form/',
      tabularFileImportUrl: '/data_set_manager/import/metadata-table-form/',
      uploadUrl: '/data_set_manager/import/chunked-upload/',
      uploadCompleteUrl: '/data_set_manager/import/chunked-upload-complete/', 

Endpoints which are being hit by the current data-set-import

View methods are being used by the current data-set-import module.

Copy link
Member

@hackdna hackdna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refinery/templates/data_set_manager folder should be also removed if it's empty

@mccalluc
Copy link
Member Author

Replaced by #2059

@mccalluc mccalluc closed this Aug 28, 2017
@mccalluc mccalluc deleted the mccalluc/remove-used-dataset-import-template branch August 28, 2017 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants