Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mccalluc/data sets to plain data sets #2021

Merged
merged 4 commits into from Aug 23, 2017

Conversation

mccalluc
Copy link
Member

@mccalluc mccalluc commented Aug 18, 2017

and Fix #2014. (Looking at it, I realize this builds from #2020 instead of starting fresh. Not a big deal, but I apologize.)

@codecov-io
Copy link

codecov-io commented Aug 18, 2017

Codecov Report

Merging #2021 into develop will increase coverage by 0.03%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2021      +/-   ##
===========================================
+ Coverage    44.18%   44.22%   +0.03%     
===========================================
  Files          416      416              
  Lines        27744    27711      -33     
  Branches      1339     1339              
===========================================
- Hits         12259    12254       -5     
+ Misses       15485    15457      -28
Impacted Files Coverage Δ
refinery/tool_manager/models.py 94.97% <ø> (ø) ⬆️
...ui/source/js/user-file-browser/services/factory.js 40.54% <ø> (ø) ⬆️
refinery/ui/source/js/commons/router/state.js 68.18% <ø> (ø) ⬆️
refinery/core/models.py 62.56% <ø> (ø) ⬆️
refinery/core/urls.py 100% <ø> (ø) ⬆️
refinery/ui/source/js/data-set-nav/state.js 70% <ø> (ø) ⬆️
...file-browser/ctrls/user-file-browser-files-ctrl.js 11.76% <ø> (ø) ⬆️
refinery/tool_manager/tests.py 99.79% <ø> (ø) ⬆️
...e/js/data-set-import/controllers/isa-tab-import.js 38.63% <0%> (ø) ⬆️
...e/js/data-set-import/controllers/metadata-table.js 21.71% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33d8d5...4c70442. Read the comment docs.

@mccalluc mccalluc merged commit 61ebee1 into develop Aug 23, 2017
@mccalluc mccalluc deleted the mccalluc/data-sets-to-plain-data-sets branch August 23, 2017 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants