New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mccalluc/details tab #2060
Mccalluc/details tab #2060
Conversation
…st expression, to match expression above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, check out
refinery-platform/refinery/templates/core/data_set.html
Lines 585 to 595 in 0701a35
{% if isatab_archive and data_set.is_public and data_set.get_owner_username != user.username and user.id %} | |
<form id="isaTabImportForm" enctype="multipart/form-data" action="{% url "take_ownership_of_public_dataset" %}" method="post"> | |
{% csrf_token %} | |
<p> | |
<input id="id_isa_tab_url" type="hidden" name="isa_tab_url" value="{{ isatab_archive.get_datafile_url }}" /> | |
</p> | |
<input class="refinery-base btn btn-important" | |
id="isa-import-button" type="submit" value="Import into own Space"/> | |
<div style="padding: 15px; display: block; height: 22px; width: 22px;" id="isa-spinner"></div> | |
</form> | |
{% endif %} |
@scottx611x : Thanks: If you have thoughts on the two questions at the top, let me know? |
Codecov Report
@@ Coverage Diff @@
## develop #2060 +/- ##
========================================
Coverage 44.22% 44.22%
========================================
Files 417 417
Lines 27729 27729
Branches 1340 1340
========================================
Hits 12263 12263
Misses 15466 15466 Continue to review full report at Codecov.
|
@mccalluc regarding the As for the creation date of the newest version I think that would be great to include. |
Towards #1890.
Two questions about the old one, copied from the thread there:
This does not come through because in the source code we have
... which seems more like a feature than a bug?
Also: New one is missing creation date of the current version: Should that also be ported from the old version?
Import into Own Space
might be more complicated, but this much could be merged, I think.original:
with this pr: