Scottx611x/fix same name analysis results #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess if there is > 1 corresponding AnalysisResults
…alysis.attach_outputs_dataset()`
…on output, but this isn't necessarily a failure state
…'s nodes after they've been populated.
Codecov Report
@@ Coverage Diff @@
## develop #2099 +/- ##
===========================================
+ Coverage 45.47% 47.13% +1.65%
===========================================
Files 411 411
Lines 27799 28583 +784
Branches 1313 1313
===========================================
+ Hits 12642 13472 +830
+ Misses 15157 15111 -46
Continue to review full report at Codecov.
|
…()` by constraining query to Nodes used as input for a given analysis run.
…lysisNodeConnection in the case where there are many results w/ the same name. Needs tests
…n have the same name
…ence the same methods.
…rt against more readable
scottx611x
commented
Sep 11, 2017
refinery/core/models.py
Outdated
| # attribute to the derived data file node to indicate | ||
| # which output of the tool it corresponds to | ||
| # connect outputs that are not inputs for any data transformation | ||
| # attribute to the derived data file node to |
|
default dict usage, tuples for mapping |
… AnalysisResult mapping as its more clear than a dict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a DataSetCollection is used as input to a workflow which only accepts a
data_input, said workflow will be run (N x the number of elements in the collection) with the potential to create N derived data nodes with the same name if the workflow doesn't have a dynamically namedlabelfor it'soutputs.Analysis.attach_outputs_dataset()had logic in place to not attach derived data nodes to their AnalysisNodeConnections if this scenario occured, but this is behavior that we would like now.Reviewed side by side w/ @mccalluc