Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable maximizing webdriver browser window in tests #2181

Merged
merged 1 commit into from Sep 25, 2017

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Sep 21, 2017

Workaround for #2067

@hackdna hackdna changed the title Testing a workaround for #2067 Disable maximizing webdriver browser window in tests Sep 21, 2017
@codecov-io
Copy link

Codecov Report

Merging #2181 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2181      +/-   ##
===========================================
- Coverage    46.36%   46.36%   -0.01%     
===========================================
  Files          412      412              
  Lines        27972    27971       -1     
  Branches      1312     1312              
===========================================
- Hits         12970    12969       -1     
  Misses       15002    15002
Impacted Files Coverage Δ
refinery/selenium_testing/utils.py 81.01% <ø> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f4c67...fdd7121. Read the comment docs.

Copy link
Member

@mccalluc mccalluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure: Scott has a vague memory that tests at some point required this, but probably just treat that as something to keep in mind for the future.

@hackdna hackdna merged commit 95c6c74 into develop Sep 25, 2017
@hackdna hackdna deleted the hackdna/test-suite-hang-fix branch September 25, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants