Mccalluc/provvis regression #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2223 +/- ##
========================================
Coverage 48.64% 48.64%
========================================
Files 412 412
Lines 28172 28172
Branches 1312 1312
========================================
Hits 13704 13704
Misses 14468 14468Continue to review full report at Codecov.
|
scottx611x
approved these changes
Oct 11, 2017
|
Also you may want to hold off on merging since our outdated version of bower is causing builds to fail. I have a PR right now that will fix it though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went a lot farther down this path, but then realized that my edits weren't actually being deployed. In any event, I'm pretty much flying blind here: There is so much functionality behind this, and my only test is whether a rectangle shows up on the screen, and even that is not automated.