-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mccalluc/cypress continued #2239
Changes from 64 commits
c6b9182
39ab46d
19037ee
7ce33b8
77a047a
31bc98d
f7f9333
78bda40
47878f6
d72508d
9c9b7ab
d8351e8
55d6eb9
67eb7ea
11378de
33f6e3e
246b5f4
052d97a
65015c6
96e0769
d268abf
bc4f4ba
87b28f2
6e44277
e3c8d00
1f49925
e2e119c
f5b28c3
d6c9c62
c5169af
5b2f449
f98537a
513a739
17b0652
3834332
0cfd64b
c63632e
af5d3bf
9345e58
bc71aff
11d15e5
2e394b5
c733257
3316c7a
0dadab5
a91e784
5e02ecb
d6df9c8
2ad1d18
dce68c2
0e11f2a
9337001
1d7884e
8dafb24
f865346
98d48fc
b980714
d4012ba
e018b4c
53ab0ec
80372d1
3ef7916
73c899b
81222f7
62bdcc6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,4 +19,4 @@ | |
ensure => 'link', | ||
target => $install_path | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,6 @@ | |
TEMPLATE_DEBUG = DEBUG | ||
|
||
# Required when DEBUG = False | ||
ALLOWED_HOSTS = get_setting("ALLOWED_HOSTS") | ||
ALLOWED_HOSTS = get_setting("ALLOWED_HOSTS") # NOQA: F405 | ||
|
||
EMAIL_BACKEND = "django.core.mail.backends.smtp.EmailBackend" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @scottx611x : Looking at this again, I remember that we did need to add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, both are needed in production. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @hackdna Doesn't the We were wondering if this was even needed in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. The purpose of a prod config is to run the site with real users which means you need a real SMTP backend to send email. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Talking with Scott, realized that we were probably too fixated on running these tests in production mode. If we we ran it in development mode, the only real difference is that if something did go wrong we'd get the extra debug information, and that's a good thing. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# custom settings for production environment | ||
|
||
from .prod import * # NOQA | ||
|
||
EMAIL_BACKEND = "django.core.mail.backends.console.EmailBackend" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"baseUrl": "http://127.0.0.1:8000", | ||
"projectId": "odo3mu" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"meta": { | ||
"total_count": 1 | ||
}, | ||
"objects": [ | ||
{ | ||
"id": 28, | ||
"measurement": null, | ||
"technology": null, | ||
"uuid": "7c532f21-d4c4-40da-83c4-9a72ade5c80f" | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{ | ||
"owner": "9bf8da15-9688-4965-aa69-9ed4c31fef83", | ||
"share_list": [ | ||
{ | ||
"group_id": 189, | ||
"group_name": "group_1508275589185", | ||
"group_uuid": "9acd285d-2599-4c13-a51f-b42551904cb3", | ||
"perms": { | ||
"change": false, | ||
"read": false | ||
} | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This configuration doesn't test any actual scenario. In dev mode Django devserver is used with
DEBUG=True
. In prod mode Apache is used withDEBUG=False
.Also, there are very few bugs that could appear in prod mode but not in dev and they would be highly dependent on the deployment environment anyway, so I would simply run Cypress tests with dev settings.