Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/analysis launch ui removal #2248

Merged
merged 5 commits into from Oct 26, 2017
Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Oct 19, 2017

@jkmarx jkmarx added this to the Release 1.6.1 milestone Oct 19, 2017
@jkmarx jkmarx self-assigned this Oct 19, 2017
@codecov-io
Copy link

codecov-io commented Oct 19, 2017

Codecov Report

Merging #2248 into develop will increase coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2248      +/-   ##
===========================================
+ Coverage    49.49%   50.18%   +0.69%     
===========================================
  Files          419      377      -42     
  Lines        27637    26872     -765     
  Branches      1310     1241      -69     
===========================================
- Hits         13679    13486     -193     
+ Misses       13958    13386     -572
Impacted Files Coverage Δ
refinery/ui/source/js/data-set-nav/state.js 100% <ø> (+30%) ⬆️
refinery/ui/source/js/refinery.js 100% <ø> (+22.22%) ⬆️
...efinery/ui/source/js/commons/services/workflows.js 25% <0%> (-75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6097bb5...d6d0ac9. Read the comment docs.

Copy link
Member

@scottx611x scottx611x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

jkmarx and others added 3 commits October 25, 2017 11:02
* Remove node-relationship module.

* Remove node-mapping module and add third party dependency to refinery… (#2250)

* Remove node-mapping module and add third party dependency to refinery.js.

* Jkmarx/decongest data set nav ui (#2268)

* Clean up data-set-nav and remove references.

* Update unit tests.

* Jkmarx/remove select workflows and igv module (#2269)

* Remove select workflow module.

* Remove igv module.

* Fix typo ,
@jkmarx jkmarx merged commit 2f412db into develop Oct 26, 2017
@jkmarx jkmarx deleted the jkmarx/analysis-launch-ui-removal branch October 26, 2017 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants