Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Not" -> "Note", and linebreaks on <br> for readability in source. #2252

Merged
merged 2 commits into from Oct 25, 2017
Merged

"Not" -> "Note", and linebreaks on <br> for readability in source. #2252

merged 2 commits into from Oct 25, 2017

Conversation

mccalluc
Copy link
Member

Fix #2162

@codecov-io
Copy link

codecov-io commented Oct 19, 2017 •
edited

Codecov Report

Merging #2252 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2252      +/-   ##
===========================================
+ Coverage    49.55%   49.55%   +<.01%     
===========================================
  Files          416      416              
  Lines        27544    27546       +2     
  Branches      1307     1307              
===========================================
+ Hits         13649    13651       +2     
  Misses       13895    13895
Impacted Files Coverage Δ
.../js/dashboard/services/intros/satori-list-graph.js 24.09% <100%> (+1.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec84db8...732f0c2. Read the comment docs.

scottx611x
scottx611x approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@scottx611x scottx611x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with this as long as you've poked around the ui and seen a working state

@scottx611x scottx611x merged commit 062e448 into develop Oct 25, 2017
@scottx611x scottx611x deleted the mccalluc/satori-typo-fix branch October 25, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottx611x scottx611x scottx611x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mccalluc @codecov-io @scottx611x