Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide any users without profiles or a full_name. #2440

Merged
merged 1 commit into from Dec 18, 2017
Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Dec 18, 2017

Ref #2121
Unsure why users want this page, since group info is provided on the collaboration page. The collaboration page is getting an overhaul next year, so this pull request addresses the bug.

@jkmarx jkmarx requested a review from mccalluc December 18, 2017 16:19
@jkmarx jkmarx self-assigned this Dec 18, 2017
@jkmarx jkmarx added this to the Release 1.6.2 milestone Dec 18, 2017
Copy link
Member

@mccalluc mccalluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but I'd still like to keep the bug open and just get rid of the page entirely, unless someone can articulate a reason we need both.

@jkmarx jkmarx merged commit ae30c95 into develop Dec 18, 2017
@jkmarx jkmarx deleted the jkmarx/fix-group-bug branch December 18, 2017 19:04
@jkmarx jkmarx added this to Doing in JM Tasks 1.6.6 Jan 2, 2018
@jkmarx jkmarx moved this from Doing to Closed in JM Tasks 1.6.6 Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants