Scottx611x/expose extra directories #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccalluc
reviewed
Dec 19, 2017
refinery/tool_manager/models.py
Outdated
| self.NODE_INFORMATION: self._get_detailed_input_nodes_dict(), | ||
| ToolDefinition.EXTRA_DIRECTORIES: ( | ||
| self.tool_definition.get_extra_directories() | ||
| ) |
There was a problem hiding this comment.
I don't think you need the surrounding paren here: There's no syntactic ambiguity without it.
mccalluc
reviewed
Dec 19, 2017
refinery/tool_manager/models.py
Outdated
| self.NODE_INFORMATION: self._get_detailed_input_nodes_dict(), | ||
| ToolDefinition.EXTRA_DIRECTORIES: ( | ||
| self.tool_definition.get_extra_directories() | ||
| ) |
There was a problem hiding this comment.
I don't think this should block, but the mix of self and ToolDefinition, or public and underscored confuses me, a little. Are those distinctions useful, and meaningful?
mccalluc
approved these changes
Dec 19, 2017
… make less wordy since Parameters at the moment require all of these fields.
…com/refinery-platform/refinery-platform into scottx611x/expose_extra_directories
|
Failing build See: #2348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mccalluc Please review/merge #2446 Before this one
extra_directoriesinformation toinput.jsonNote:
Heatmap ScatterplotTool launches properly with these changes, but we run into the relative paths issue again (when specifying a relative path in a VisTool things get routed through Refinery instead of the proxy) . We should really begin looking into using subdomain based routing for Vis Tools