Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slug edit from import form. #2473

Merged
merged 1 commit into from Jan 17, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jan 17, 2018

Resolves #1629

@jkmarx jkmarx added this to the Release 1.6.2 milestone Jan 17, 2018
@jkmarx jkmarx self-assigned this Jan 17, 2018
@jkmarx jkmarx requested a review from mccalluc January 17, 2018 14:27
@codecov
Copy link

codecov bot commented Jan 17, 2018

Codecov Report

Merging #2473 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2473      +/-   ##
===========================================
+ Coverage    51.52%   51.53%   +0.01%     
===========================================
  Files          389      389              
  Lines        27106    27097       -9     
  Branches      1247     1245       -2     
===========================================
- Hits         13966    13965       -1     
+ Misses       13140    13132       -8
Impacted Files Coverage Δ
...e/js/data-set-import/controllers/metadata-table.js 21.96% <ø> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b913020...361ad36. Read the comment docs.

@jkmarx jkmarx merged commit e6c70a4 into develop Jan 17, 2018
@jkmarx jkmarx deleted the jkmarx/remove-url-shortcut-from-import branch January 17, 2018 16:18
@hackdna
Copy link
Member

hackdna commented Jan 17, 2018

Slug handling should also be removed from the corresponding server side code, for example:

slug=request.POST.get('slug'),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants