Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap deprecated method out. #2566

Merged
merged 2 commits into from Feb 9, 2018
Merged

Swap deprecated method out. #2566

merged 2 commits into from Feb 9, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Feb 7, 2018

Ref #449

@codecov
Copy link

codecov bot commented Feb 7, 2018 •
edited

Codecov Report

Merging #2566 into jkmarx/update-httpresponse will decrease coverage by 0.29%.
The diff coverage is 0%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           jkmarx/update-httpresponse   #2566     +/-   ##
============================================================
- Coverage                        52.6%   52.3%   -0.3%     
============================================================
  Files                             415     415             
  Lines                           27469   27857    +388     
  Branches                         1240    1240             
============================================================
+ Hits                            14450   14571    +121     
- Misses                          13019   13286    +267
Impacted Files Coverage Δ
...tion_server/management/commands/create_taxonomy.py 0% <0%> (ø) ⬆️
refinery/core/urls.py 100% <0%> (ø) ⬆️
refinery/visualization_manager/views.py 8.81% <0%> (+0.37%) ⬆️
refinery/core/views.py 29.27% <0%> (+2.64%) ⬆️
refinery/analysis_manager/utils.py 65.07% <0%> (+9.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6801aa0...df7df49. Read the comment docs.

@jkmarx jkmarx added this to the Release 1.6.3 milestone Feb 7, 2018
@jkmarx jkmarx self-assigned this Feb 7, 2018
scottx611x
scottx611x approved these changes Feb 7, 2018
View reviewed changes
Copy link
Member

@scottx611x scottx611x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

We could probably utilize something like the following which would handle the rolling back for us:

try:
    with transaction.atomic():
        taxon.save()
        sys.stdout.write("%s created." % taxon)
except IntegrityError:
    sys.stdout.write("Duplicate Value %s" % taxon)

Bigger question is if we even need create_taxonomy anymore

@jkmarx
Remove solr_igv dependencies. (#2570)
df7df49 
* Remove solr_igv dependencies.

* Remove visualization_manager.

* Upgrade django storage. (#2571)

* Upgrade django storage.

* Remove post-css library, unused. (#2574)

* Update user/file facet/columns per user request. (#2577)

* Remove post-css library, unused.

* Update user/file facet/columns per user request.

* Remove typo ,

* Fix typo, double quotes.

* Remove space.

* Add cell_type to facets.

* Fix unit test.

* Add missing facets.

* Fix cypress test.

* Revert to 1.6.0 due to django 1.9 support.
@jkmarx jkmarx merged commit ca22e4c into jkmarx/update-httpresponse Feb 9, 2018
@jkmarx jkmarx deleted the jkmarx/remove-transaction-management-apis branch February 9, 2018 03:53
jkmarx added a commit that referenced this pull request Feb 12, 2018
@jkmarx
Jkmarx/update httpresponse (#2533)
6293e63 
* Update workflow_manager httpReponse to jsonReponse.

* Add allowed_hosts to dev setting.

* Update comment.

* Remove conflicting settings, model can only have one of add, add_on, or default.

* Update analysis_manager httpReponse to jsonResponse.

* Add migrations.

* Update module_name with model name.

* Refactor.

* Upgrade some dependencies for django 1.8

* Revert to minimum dependency upgrade to resolve migration issue.

* Update annotation server with jsonResponse.

* Update core and data_set_manager apps.

* Fix typo.

* Update requirements to fix migration issue.

* Try release which seperates dependency on User module.

* Check to see if chunked-upload is the problem.

* Fix bug related to abstract model causing migration to fail for library.

* Remove duplicate setting.

* Track migration until library updates

* Reorder installed apps per redux docs.

* Update activate_user with parser.

* Fix pep8 in migration.

* Remove unit test due to inaccurate scope.

* Add mocks to unit test.

* Remove unneccessary deletion.

* Fix selium unit test errors.

* Remove accidently added json

* Jkmarx/registration redux upgrade (#2562)

* update redux.

* Update method params changed from upgrade

* Update flockblock params due to upgrade.

* Refactor, return_value to inline.

* Fix unit test.

* Fix mistake using jsonresponse with a str.

* Remove typo.

* Remove unneeded field.

* Chunked_upload migration.

* Opt for safer option for jsonResponse.

* Fix syntax.

* Fix pep8.

* Swap deprecated method out. (#2566)

* Swap deprecated method out.

* Remove solr_igv dependencies. (#2570)

* Remove solr_igv dependencies.

* Remove visualization_manager.

* Upgrade django storage. (#2571)

* Upgrade django storage.

* Remove post-css library, unused. (#2574)

* Update user/file facet/columns per user request. (#2577)

* Remove post-css library, unused.

* Update user/file facet/columns per user request.

* Remove typo ,

* Fix typo, double quotes.

* Remove space.

* Add cell_type to facets.

* Fix unit test.

* Add missing facets.

* Fix cypress test.

* Revert to 1.6.0 due to django 1.9 support.

* Remove unnessary flake8 ignore.

* Add json.load exception.
scottx611x pushed a commit that referenced this pull request Feb 21, 2018
@jkmarx @scottx611x
Upgrade django version to 1.8 (#2560)
ae273b9 
* Upgrade django version to 1.8

* Update workflow_manager httpReponse to jsonReponse.

* Add allowed_hosts to dev setting.

* Update comment.

* Remove conflicting settings, model can only have one of add, add_on, or default.

* Update analysis_manager httpReponse to jsonResponse.

* Add migrations.

* Update module_name with model name.

* Refactor.

* Upgrade some dependencies for django 1.8

* Revert to minimum dependency upgrade to resolve migration issue.

* Update annotation server with jsonResponse.

* Update core and data_set_manager apps.

* Fix typo.

* Update requirements to fix migration issue.

* Try release which seperates dependency on User module.

* Check to see if chunked-upload is the problem.

* Fix bug related to abstract model causing migration to fail for library.

* Remove duplicate setting.

* Track migration until library updates

* Reorder installed apps per redux docs.

* Update activate_user with parser.

* Fix pep8 in migration.

* Remove unit test due to inaccurate scope.

* Add mocks to unit test.

* Remove unneccessary deletion.

* Fix selium unit test errors.

* Remove accidently added json

* Jkmarx/registration redux upgrade (#2562)

* update redux.

* Update method params changed from upgrade

* Update flockblock params due to upgrade.

* Refactor, return_value to inline.

* Fix unit test.

* Fix mistake using jsonresponse with a str.

* Remove typo.

* Remove unneeded field.

* Chunked_upload migration.

* Opt for safer option for jsonResponse.

* Fix syntax.

* Fix pep8.

* Swap deprecated method out. (#2566)

* Swap deprecated method out.

* Remove solr_igv dependencies. (#2570)

* Remove solr_igv dependencies.

* Remove visualization_manager.

* Upgrade django storage. (#2571)

* Upgrade django storage.

* Remove post-css library, unused. (#2574)

* Update user/file facet/columns per user request. (#2577)

* Remove post-css library, unused.

* Update user/file facet/columns per user request.

* Remove typo ,

* Fix typo, double quotes.

* Remove space.

* Add cell_type to facets.

* Fix unit test.

* Add missing facets.

* Fix cypress test.

* Revert to 1.6.0 due to django 1.9 support.

* Remove unnessary flake8 ignore.

* Add json.load exception.

* Jkmarx/update httpresponse (#2533)

* Update workflow_manager httpReponse to jsonReponse.

* Add allowed_hosts to dev setting.

* Update comment.

* Remove conflicting settings, model can only have one of add, add_on, or default.

* Update analysis_manager httpReponse to jsonResponse.

* Add migrations.

* Update module_name with model name.

* Refactor.

* Upgrade some dependencies for django 1.8

* Revert to minimum dependency upgrade to resolve migration issue.

* Update annotation server with jsonResponse.

* Update core and data_set_manager apps.

* Fix typo.

* Update requirements to fix migration issue.

* Try release which seperates dependency on User module.

* Check to see if chunked-upload is the problem.

* Fix bug related to abstract model causing migration to fail for library.

* Remove duplicate setting.

* Track migration until library updates

* Reorder installed apps per redux docs.

* Update activate_user with parser.

* Fix pep8 in migration.

* Remove unit test due to inaccurate scope.

* Add mocks to unit test.

* Remove unneccessary deletion.

* Fix selium unit test errors.

* Remove accidently added json

* Jkmarx/registration redux upgrade (#2562)

* update redux.

* Update method params changed from upgrade

* Update flockblock params due to upgrade.

* Refactor, return_value to inline.

* Fix unit test.

* Fix mistake using jsonresponse with a str.

* Remove typo.

* Remove unneeded field.

* Chunked_upload migration.

* Opt for safer option for jsonResponse.

* Fix syntax.

* Fix pep8.

* Swap deprecated method out. (#2566)

* Swap deprecated method out.

* Remove solr_igv dependencies. (#2570)

* Remove solr_igv dependencies.

* Remove visualization_manager.

* Upgrade django storage. (#2571)

* Upgrade django storage.

* Remove post-css library, unused. (#2574)

* Update user/file facet/columns per user request. (#2577)

* Remove post-css library, unused.

* Update user/file facet/columns per user request.

* Remove typo ,

* Fix typo, double quotes.

* Remove space.

* Add cell_type to facets.

* Fix unit test.

* Add missing facets.

* Fix cypress test.

* Revert to 1.6.0 due to django 1.9 support.

* Remove unnessary flake8 ignore.

* Add json.load exception.

* Jkmarx/remove unused m commands (#2583)

* Remove unused management commands.

* Remove unused method.

* Jkmarx/outparse to argparse (#2584)

* Update make_options to add_arguments for optparse/argparse upgrade.

* Refactor for easier read.

* Jkmarx update deprecated 1 8 items (#2588)

* Update config with the new 1.8 setting.

* Add comment.

* Remove unused template.

* Update template related settings.

* Update get_template per docs, Context&RequestContext unneeded.

* Fix typo in context_processors location update.

* Remove duplicate.

* Fix added setting.

* Add `--fake-initial` to our migrate commands to provide the behavior that Django 1.7 gave by default (#2585)

* Update management command, argparse.

* Scottx611x/fix management commands (#2606)

* Update `set_uo_site_name` to use add_arguments()

* Add test coverage

* Add test for `add_users_to_public_group`

* Add test for user activation

* Add test for `import_annotations`

* Move for consistency.

* Jkmarx/update management command argparse (#2607)

* Update management command, argparse.

* Move for consistency.

* Add tests for `create_workflow_engine`

* Add tests for `create_galaxy_instance`

* Fix bug related to non-obj.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottx611x scottx611x scottx611x approved these changes

Assignees

@jkmarx jkmarx

Labels
None yet
Projects
None yet
Milestone
Release 1.6.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkmarx @scottx611x