Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DiskQuota model #2599

Merged
merged 2 commits into from Feb 16, 2018
Merged

Remove DiskQuota model #2599

merged 2 commits into from Feb 16, 2018

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Feb 15, 2018

Close #2465

Ontology, Project, SiteProfile, Tutorials, UserProfile,
Workflow, WorkflowDataInput, WorkflowDataInputMap,
WorkflowEngine, WorkflowInputRelationships)
from .utils import admin_ui_deletion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the DiskQuotaAdmin class?

@codecov
Copy link

codecov bot commented Feb 15, 2018

Codecov Report

Merging #2599 into develop will decrease coverage by 2.77%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2599      +/-   ##
===========================================
- Coverage    55.76%   52.98%   -2.78%     
===========================================
  Files          408      406       -2     
  Lines        29588    26409    -3179     
  Branches      1240     1240              
===========================================
- Hits         16500    13994    -2506     
+ Misses       13088    12415     -673
Impacted Files Coverage Δ
refinery/core/models.py 71.33% <ø> (-3.32%) ⬇️
refinery/core/admin.py 85.26% <100%> (-0.46%) ⬇️
refinery/analysis_manager/utils.py 55.1% <0%> (-9.98%) ⬇️
refinery/data_set_manager/tasks.py 36.99% <0%> (-5.52%) ⬇️
refinery/data_set_manager/views.py 45.49% <0%> (-5.01%) ⬇️
refinery/file_store/models.py 62.45% <0%> (-4.3%) ⬇️
refinery/analysis_manager/views.py 46.78% <0%> (-3.55%) ⬇️
refinery/core/views.py 26.57% <0%> (-3.15%) ⬇️
...ery/tool_manager/management/commands/load_tools.py 85.03% <0%> (-1.21%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697634a...5fca4c8. Read the comment docs.

@hackdna hackdna merged commit 37d6b48 into develop Feb 16, 2018
Technical Debt automation moved this from Backlog to Done Feb 16, 2018
@hackdna hackdna deleted the hackdna/remove-diskquota branch February 16, 2018 13:59
Copy link
Member

@mccalluc mccalluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants