Jkmarx/connect add file service #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry-platform into jkmarx/data-file-replace-modal
…ry-platform into jkmarx/data-file-replace-modal
…ry-platform into jkmarx/data-file-replace-modal
…ry-platform into jkmarx/data-file-replace-modal
jkmarx
changed the base branch from
develop
to
jkmarx-data-file-modal-unit-tests
Codecov Report
@@ Coverage Diff @@
## develop #2838 +/- ##
===========================================
- Coverage 58.29% 58.21% -0.08%
===========================================
Files 430 430
Lines 26837 26700 -137
Branches 1292 1262 -30
===========================================
- Hits 15644 15544 -100
+ Misses 11193 11156 -37
Continue to review full report at Codecov.
|
…ry-platform into jkmarx-data-file-modal-unit-tests
…m/refinery-platform/refinery-platform into jkmarx/connect-add-file-service
scottx611x
approved these changes
Jul 2, 2018
refinery/data_set_manager/views.py
Outdated
| def post(self, request): | ||
| try: | ||
| data_set = DataSet.objects.get(uuid=request.POST['data_set_uuid']) | ||
| data_set = DataSet.objects.get(uuid=request | ||
| .data.get('data_set_uuid')) | ||
| except KeyError: |
There was a problem hiding this comment.
I don't think this KeyError has the potential to be raised anymore
There was a problem hiding this comment.
@scottx611x Yes, that got updated when I wrote some unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2700