Add unit tests for api. #2839
Merged
Add unit tests for api. #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## jkmarx/connect-add-file-service #2839 +/- ##
===================================================================
- Coverage 58.24% 58.21% -0.04%
===================================================================
Files 430 430
Lines 26736 26700 -36
Branches 1262 1262
===================================================================
- Hits 15573 15544 -29
+ Misses 11163 11156 -7
Continue to review full report at Codecov.
|
scottx611x
approved these changes
Jul 2, 2018
scottx611x
approved these changes
Jul 2, 2018
jkmarx
added a commit
that referenced
this pull request
Jul 2, 2018
* Add modal. * Pass node info. * Add libraries. * Add node info and add/remove features. * Fix unit test. * Add disabled templates. * Disable lightening bolt button. * Update file for single node update. * Update local file-upload partial. * Update s3 html for node updates. * Split file-upload into seperate components. * Update s3 partial with node update specifics. * Fix conditional. * Update comments. * Refresh grid. * Add unit tests * Remove unused dependencies. * Update url when just adding a file. * Fix bug related to moving the ctrl to directive scope. * Refactor to DRF api. * Update clientside to add service and validation. * Limit api endpoints. * Remove lingering console. * Update s3 file-upload code. * Remove unused library. * Remove unused library. * Add service unit test. * Update text for clarity. * Remove unnesseccary text. * Add unit tests for api. (#2839) * Fix spacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Some unit tests