Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/file browser default open description #2930

Merged
merged 3 commits into from Aug 3, 2018

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Aug 3, 2018

  • Defaulted to open to help users figure out how to use the tools.
    default-open

@jkmarx jkmarx self-assigned this Aug 3, 2018
@jkmarx jkmarx requested a review from mccalluc August 3, 2018 15:00
@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #2930 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2930   +/-   ##
=======================================
  Coverage     59.4%   59.4%           
=======================================
  Files          435     435           
  Lines        27313   27313           
  Branches      1273    1273           
=======================================
  Hits         16226   16226           
  Misses       11087   11087
Impacted Files Coverage Δ
...rce/js/tool-launch/services/tool-select-service.js 85.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4186c12...6edce6b. Read the comment docs.

@jkmarx jkmarx added this to the Release 1.6.6 milestone Aug 3, 2018
@scottx611x
Copy link
Member

@jkmarx jkmarx merged commit e4eddd0 into develop Aug 3, 2018
@jkmarx jkmarx deleted the jkmarx/file-browser-default-open-description branch August 3, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants