Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to primary group on loading. #2939

Merged
merged 2 commits into from Aug 10, 2018
Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Aug 9, 2018

  • Defaults to primary group when dashboard loads, if a primary group has been selected.

@jkmarx jkmarx added this to the Release 1.6.6 milestone Aug 9, 2018
@jkmarx jkmarx self-assigned this Aug 9, 2018
@jkmarx jkmarx requested a review from mccalluc August 9, 2018 11:45
@@ -13,11 +13,13 @@

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the child component is responsible for loading the initial dashboard's data sets

@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #2939 into develop will decrease coverage by 0.32%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2939      +/-   ##
===========================================
- Coverage    59.73%   59.41%   -0.33%     
===========================================
  Files          434      435       +1     
  Lines        27767    27320     -447     
  Branches      1280     1274       -6     
===========================================
- Hits         16587    16231     -356     
+ Misses       11180    11089      -91
Impacted Files Coverage Δ
...ce/js/dashboard/controllers/data-sets-card-ctrl.js 69.02% <ø> (+0.27%) ⬆️
...dashboard/controllers/primary-group-button-ctrl.js 91.66% <66.66%> (-2.46%) ⬇️
refinery/core/views.py 42.49% <0%> (-3.84%) ⬇️
refinery/core/forms.py 78.04% <0%> (-1.37%) ⬇️
refinery/core/serializers.py 84.93% <0%> (-1.35%) ⬇️
...ry/ui/source/js/dashboard/controllers/dashboard.js 9.25% <0%> (-0.02%) ⬇️
refinery/core/urls.py 100% <0%> (ø) ⬆️
refinery/core/test_views.py 100% <0%> (ø) ⬆️
refinery/ui/source/js/commons/services/projects.js 25% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665cb1c...8655f33. Read the comment docs.

@jkmarx jkmarx merged commit 16d8a9c into develop Aug 10, 2018
@jkmarx jkmarx deleted the jkmarx/primary-group-default branch August 10, 2018 16:20
@jkmarx jkmarx added this to Closed in JM Tasks 1.6.6 Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants