Scottx611x/fix add users to public group timeout #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…member" This reverts commit 12f53c6.
…ers only; We still need to run this code for all active users during provisioning because the Neo4J database is recreated each time
ghost
assigned 
|
@mccalluc I've now been able to bring up a stack with this fix introduced |
mccalluc
approved these changes
Sep 11, 2018
scottx611x
deleted the
scottx611x/fix_add_users_to_public_group_timeout
branch
scottx611x
added a commit
that referenced
this pull request
Oct 12, 2018
* Only add a User to the Public Group if they aren't already a member * Only add user to neo4j upon initial User creation * Revert "Only add a User to the Public Group if they aren't already a member" This reverts commit 12f53c6. * Constrain User addition and annotatio set updating neo4j to active users only; We still need to run this code for all active users during provisioning because the Neo4J database is recreated each time * Reverse logic to check if a User is active and add logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to deploy an AWS instance for
hotfix-1.6.6.1I consistently ran into a timeout that didn't allow for the Puppet manifest to apply completely.This is due to the fact that we have a bunch of spam
Userinstances hanging around and for eachuser.save()being called within theadd_users_to_public_groupmgmt command_add_user_to_neo4jis being run unnecessairily.This PR only adds a user to neo4j on a
User.post_savesignal being hit if we have activated said user prior.