Jkmarx/fix transfer ownership bug #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkmarx
commented
Oct 11, 2018
jkmarx
commented
- Resolves Transfer Data Set Bug #3045
- Removes a custom data_set get_owner method which used add_ perms
…he transfer data set bug.
jkmarx
commented
Oct 11, 2018
| @@ -364,10 +367,36 @@ class SharableResource(OwnableResource): | |||
| def __unicode__(self): | |||
| return self.name | |||
|
|
|||
| def get_owner(self): | |||
There was a problem hiding this comment.
Moved from the data_set class. Fritz noted this method improved performance 10%-20% percent.
Codecov Report
@@ Coverage Diff @@
## develop #3055 +/- ##
===========================================
- Coverage 60.66% 59.78% -0.89%
===========================================
Files 434 434
Lines 27871 27111 -760
Branches 1275 1275
===========================================
- Hits 16908 16208 -700
+ Misses 10963 10903 -60
Continue to review full report at Codecov.
|
mccalluc
approved these changes
Oct 12, 2018
| pass | ||
|
|
||
| return owner | ||
|
|
There was a problem hiding this comment.
Feel free to ignore, since this is just a move, but:
- There is an
exists(), but I'd be surprised if it's much of an improvement overcount(). - Maybe just return in the try? (and get rid of
owner = Noneandreturn owner) - I can see that it's tested below, but I can't remember what it would mean to be ownerless, and how that would be useful.
| def test_set_owner_data_sets_read_meta_perms(self): | ||
| self.data_set.set_owner(self.user) | ||
| user_perms = get_perms(self.user, self.data_set) | ||
| self.assertTrue('read_meta_dataset' in user_perms) |
There was a problem hiding this comment.
I might have done all of these at once with issubset, but this works, too.
scottx611x
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.