Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove collaboration module. #3103

Merged
merged 4 commits into from
Nov 14, 2018
Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Nov 13, 2018

Ref #2680

  • Remove collaboration module and page
  • Remove front end collaboration references (tutorial)
  • Leaving the tutorial backend model until we decide how we want to handle the new dashboard's tutorials

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #3103 into develop will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3103      +/-   ##
===========================================
+ Coverage    60.62%   60.98%   +0.35%     
===========================================
  Files          431      421      -10     
  Lines        28005    27367     -638     
  Branches      1300     1264      -36     
===========================================
- Hits         16978    16689     -289     
+ Misses       11027    10678     -349
Impacted Files Coverage Δ
refinery/ui/source/js/refinery.js 100% <ø> (ø) ⬆️
...ui/source/js/commons/ctrls/group-add-modal-ctrl.js 51.72% <ø> (-3.28%) ⬇️
refinery/ui/source/js/refinery-controller.js 7.89% <ø> (-2.75%) ⬇️
refinery/core/urls.py 100% <ø> (ø) ⬆️
...e/js/commons/ctrls/group-member-edit-modal-ctrl.js 43.63% <ø> (+0.77%) ⬆️
...ce/js/commons/ctrls/group-member-add-modal-ctrl.js 58.33% <ø> (-1.29%) ⬇️
refinery/core/views.py 47.61% <ø> (-3.51%) ⬇️
...commons/directives/sharing-help-popover-details.js 100% <ø> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47235f4...679448c. Read the comment docs.

@jkmarx jkmarx self-assigned this Nov 14, 2018
@jkmarx jkmarx added this to the Release 1.6.8 milestone Nov 14, 2018
Copy link
Member

@scottx611x scottx611x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some artifacts related to the collaboration tutorials (See: collaboration_tutorial_viewed), but from what I remember in the meeting from yesterday there's going to be an overhaul of the existing tutorials anyways, correct? So this much is probably fine.

@jkmarx
Copy link
Member Author

jkmarx commented Nov 14, 2018

@scottx611x Ref #3109

@jkmarx jkmarx merged commit e878550 into develop Nov 14, 2018
@jkmarx jkmarx deleted the jkmarx/remove-collaboration-page branch November 14, 2018 17:55
@jkmarx jkmarx mentioned this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants