Jkmarx/fix analysis auto call bug #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkmarx
commented
Mar 27, 2019
jkmarx
commented
- Resolves this bug: In the file browser, when navigating away the analyses calls should stop.
- Remove reinitializing the analyses monitor controller twice (both in nav state and component)
- Remove unused helper method
Codecov Report
@@ Coverage Diff @@
## develop #3292 +/- ##
===========================================
+ Coverage 65.44% 65.59% +0.14%
===========================================
Files 379 378 -1
Lines 25201 25082 -119
Branches 941 944 +3
===========================================
- Hits 16493 16452 -41
+ Misses 8708 8630 -78
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #3292 +/- ##
===========================================
+ Coverage 65.44% 65.58% +0.13%
===========================================
Files 379 379
Lines 25201 25093 -108
Branches 941 939 -2
===========================================
- Hits 16493 16456 -37
+ Misses 8708 8637 -71
Continue to review full report at Codecov.
|
hackdna
approved these changes
Mar 28, 2019
jkmarx
added a commit
that referenced
this pull request
Apr 2, 2019
* Extend api to return all member groups. * Add unit tests. * Jkmarx/fix analysis auto call bug (#3292) * Cancel time when destory and avoid reinitializing the ctrl. * Remove unused helper method. * Remove unused unit tests. * Extend api to create groups. (#3299) * Extend group api to update group perms and retrieve all group info. * Add unit tests. * Add unit tests. * Extend group API to destroy. * Add unit tests. * Fix typo. * Jkmarx/update client with group api enhancements (#3302) * Update client. * Extend api to return can_edit field. * Add group unit tests. * Avoid unneccessary api call. (#3303)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.