Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkmarx/extend group api to delete #3307

Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Apr 2, 2019

No description provided.

jkmarx and others added 10 commits March 29, 2019 16:31
* Cancel time when destory and avoid reinitializing the ctrl.

* Remove unused helper method.

* Remove unused unit tests.
* Extend group api to update group perms and retrieve all group info.

* Add unit tests.
* Update client.

* Extend api to return can_edit field.

* Add group unit tests.

* Avoid unneccessary api call. (#3303)
@jkmarx jkmarx merged commit 75e1724 into jkmarx/extend-group-api-to-add Apr 2, 2019
@jkmarx jkmarx deleted the jkmarx/extend-group-api-to-delete branch April 2, 2019 21:41
jkmarx added a commit that referenced this pull request Apr 2, 2019
jkmarx added a commit that referenced this pull request Apr 2, 2019
@jkmarx jkmarx restored the jkmarx/extend-group-api-to-delete branch April 2, 2019 21:52
@jkmarx jkmarx deleted the jkmarx/extend-group-api-to-delete branch May 13, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant