Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_group helper method. #3316

Merged
merged 3 commits into from Apr 9, 2019
Merged

Add get_group helper method. #3316

merged 3 commits into from Apr 9, 2019

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Apr 8, 2019

  • Add helper method for uniformity when grabbing a group for an api.

@jkmarx jkmarx requested a review from hackdna April 8, 2019 18:11
@jkmarx jkmarx self-assigned this Apr 8, 2019
@jkmarx jkmarx added this to the Release 1.6.9 milestone Apr 8, 2019
@codecov
Copy link

codecov bot commented Apr 8, 2019 •
edited

Codecov Report

Merging #3316 into jkmarx/create-group-invitations-api will decrease coverage by 0.12%.
The diff coverage is 90.62%.

Impacted file tree graph

@@                           Coverage Diff                           @@
##           jkmarx/create-group-invitations-api    #3316      +/-   ##
=======================================================================
- Coverage                                67.27%   67.15%   -0.13%     
=======================================================================
  Files                                      376      376              
  Lines                                    25228    24907     -321     
  Branches                                   939      941       +2     
=======================================================================
- Hits                                     16973    16726     -247     
+ Misses                                    8255     8181      -74
Impacted Files Coverage Δ
refinery/core/test_utils.py 100% <100%> (ø) ⬆️
refinery/core/views.py 63.49% <100%> (-3.77%) ⬇️
refinery/core/utils.py 40.77% <66.66%> (ø) ⬆️
...nery/ui/source/js/commons/services/group-invite.js 100% <0%> (ø) ⬆️
...ce/js/dashboard/controllers/dashboard-main-ctrl.js 96.87% <0%> (+0.57%) ⬆️
...s/dashboard/controllers/collaboration-card-ctrl.js 65.27% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f802b6...cd37998. Read the comment docs.

@jkmarx
Jkmarx/update client to invite api v2 (#3317)
cd37998 
* Update client.

* Add unit tests.

* Fix comment.

* Update delete call.

* Remove tasty pie. (#3318)
@jkmarx jkmarx merged commit d537e9e into jkmarx/create-group-invitations-api Apr 9, 2019
@jkmarx jkmarx deleted the jkmarx/add-helper-method-get-group branch April 9, 2019 16:19
jkmarx added a commit that referenced this pull request Apr 9, 2019
@jkmarx
Jkmarx/create group invitations api (#3314)
2f40abf 
* Create invitation v2 api.

* Extend api to partial_update.

* Fix comments.

* Remove data packet from delete.

* Add get_group helper method. (#3316)

* Add get_group helper method.

* Jkmarx/update client to invite api v2 (#3317)

* Update client.

* Fix comment.

* Update delete call.

* Remove tasty pie. (#3318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackdna hackdna hackdna approved these changes

Assignees

@jkmarx jkmarx

Labels
api technical debt
Projects
None yet
Milestone
Release 1.6.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkmarx @hackdna