Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tasty pie. #3318

Merged

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Apr 9, 2019

Resolves #2618

@jkmarx jkmarx self-assigned this Apr 9, 2019
@jkmarx jkmarx requested a review from hackdna April 9, 2019 12:07
@jkmarx jkmarx added this to the Release 1.6.9 milestone Apr 9, 2019
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #3318 into jkmarx/update-client-to-invite-api-v2 will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@                            Coverage Diff                            @@
##           jkmarx/update-client-to-invite-api-v2    #3318      +/-   ##
=========================================================================
+ Coverage                                  67.14%   67.25%   +0.11%     
=========================================================================
  Files                                        376      374       -2     
  Lines                                      24892    24788     -104     
  Branches                                     940      940              
=========================================================================
- Hits                                       16713    16672      -41     
+ Misses                                      8179     8116      -63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9362d...72b0045. Read the comment docs.

@jkmarx jkmarx merged commit a72ca22 into jkmarx/update-client-to-invite-api-v2 Apr 9, 2019
@jkmarx jkmarx deleted the jkmarx/remove-tasty-pie branch April 9, 2019 16:19
jkmarx added a commit that referenced this pull request Apr 9, 2019
* Update client.

* Add unit tests.

* Fix comment.

* Update delete call.

* Remove tasty pie. (#3318)
jkmarx added a commit that referenced this pull request Apr 9, 2019
* Add get_group helper method.

* Jkmarx/update client to invite api v2 (#3317)

* Update client.

* Add unit tests.

* Fix comment.

* Update delete call.

* Remove tasty pie. (#3318)
jkmarx added a commit that referenced this pull request Apr 9, 2019
* Create invitation v2 api.

* Extend api to partial_update.

* Fix comments.

* Remove data packet from delete.

* Add get_group helper method. (#3316)

* Add get_group helper method.

* Jkmarx/update client to invite api v2 (#3317)

* Update client.

* Fix comment.

* Update delete call.

* Remove tasty pie. (#3318)
@jkmarx jkmarx mentioned this pull request Apr 9, 2019
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants