New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Analysis Metadata Fetching for Celery #3461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3461 +/- ##
===========================================
- Coverage 88.22% 87.41% -0.82%
===========================================
Files 96 96
Lines 17170 14796 -2374
===========================================
- Hits 15149 12934 -2215
+ Misses 2021 1862 -159
Continue to review full report at Codecov.
|
ilan-gold
commented
Oct 16, 2019
ilan-gold
commented
Oct 16, 2019
ilan-gold
changed the title
Speed Up Celery Post-Analysis
Restructure Analysis Metadata Fetching for Celery
Oct 18, 2019
hackdna
reviewed
Oct 21, 2019
hackdna
reviewed
Oct 21, 2019
hackdna
reviewed
Oct 21, 2019
hackdna
reviewed
Oct 21, 2019
hackdna
reviewed
Oct 21, 2019
hackdna
reviewed
Oct 22, 2019
hackdna
reviewed
Oct 22, 2019
hackdna
reviewed
Oct 22, 2019
hackdna
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up Celery by storing results of multiple API calls (that don't change) in a table / using existing stored information instead of making the request. This addresses both #2642 and #3435. The speed up is drastic, and gets larger (in absolute terms) the more requests that are made. Benchmarking is in #3435 but it appears that the speed up is on the magnitude of 5x or greater for large calls.