Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Analysis Metadata Fetching for Celery #3461

Merged
merged 36 commits into from Oct 22, 2019

Conversation

ilan-gold
Copy link
Member

@ilan-gold ilan-gold commented Oct 8, 2019

Speed up Celery by storing results of multiple API calls (that don't change) in a table / using existing stored information instead of making the request. This addresses both #2642 and #3435. The speed up is drastic, and gets larger (in absolute terms) the more requests that are made. Benchmarking is in #3435 but it appears that the speed up is on the magnitude of 5x or greater for large calls.

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #3461 into develop will decrease coverage by 0.81%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3461      +/-   ##
===========================================
- Coverage    88.22%   87.41%   -0.82%     
===========================================
  Files           96       96              
  Lines        17170    14796    -2374     
===========================================
- Hits         15149    12934    -2215     
+ Misses        2021     1862     -159
Impacted Files Coverage Δ
refinery/tool_manager/tests.py 99.89% <100%> (-0.04%) ⬇️
refinery/analysis_manager/tasks.py 72.04% <100%> (-0.1%) ⬇️
refinery/tool_manager/models.py 95.32% <78.57%> (-0.64%) ⬇️
refinery/data_set_manager/views.py 65.71% <0%> (-4.65%) ⬇️
refinery/core/views.py 69.24% <0%> (-3.4%) ⬇️
refinery/core/models.py 82.47% <0%> (-3.39%) ⬇️
refinery/tool_manager/views.py 92.3% <0%> (-0.82%) ⬇️
refinery/analysis_manager/test_tasks.py 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f92d5...63106a0. Read the comment docs.

@ilan-gold ilan-gold removed the request for review from jkmarx October 10, 2019 14:13
@ilan-gold ilan-gold changed the title Speed Up Celery Post-Analysis Restructure Analysis Metadata Fetching for Celery Oct 18, 2019
refinery/core/models.py Outdated Show resolved Hide resolved
refinery/core/models.py Outdated Show resolved Hide resolved
@ilan-gold ilan-gold merged commit 223158a into develop Oct 22, 2019
@ilan-gold ilan-gold deleted the ilan-gold/celery_bug branch October 22, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants