Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render_with_templates? not available to engines #1901

Closed
mhinton opened this issue Aug 26, 2012 · 5 comments
Closed

render_with_templates? not available to engines #1901

mhinton opened this issue Aug 26, 2012 · 5 comments

Comments

@mhinton
Copy link

mhinton commented Aug 26, 2012

The PagesController method render_with_templates? is not available to the other engines. I have to move render_with_templates? up to the ApplicationController and add the line render_with_templates?(:action => params[:action]) to new and thank_you in the InquiriesController to be able to change the layout used.

@parndt
Copy link
Member

parndt commented Aug 26, 2012

Should it be available to other extensions? It's functionality that is specific to the pages extension.

Or does it not work when you're visiting a particular page?

@mhinton
Copy link
Author

mhinton commented Aug 27, 2012

I want to be able to specify the layout that the inquiries pages use and
by default that doesn't work. The @page object has the layout value set
but unless you use render_with_templates? the layout value isn't taken
into account.

Philip Arndt mailto:notifications@github.com
August 26, 2012 4:47 PM

Should it be available to other extensions? It's functionality that is
specific to the pages extension.

Or does it not work when you're visiting a particular page?


Reply to this email directly or view it on GitHub
https://github.com/resolve/refinerycms/issues/1901#issuecomment-8038163.

@robyurkowski
Copy link
Contributor

👍 on refactoring render_with_templates -- sheerly for the fact that you should be able to call error_404 outside of the Pages Controller.

@parndt
Copy link
Member

parndt commented Dec 20, 2012

Once #2089 is merged you'll be able to use:

include Refinery::Pages::RenderOptions

@parndt parndt closed this as completed Dec 20, 2012
@tx-tim
Copy link

tx-tim commented Apr 15, 2013

There's a discussion about this on the google group - seems it's still a problem.
https://groups.google.com/d/topic/refinery-cms/NMo4O4emPqo/discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants