Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UrlSource: add proper SSL handling #40

Closed
Pentadrago opened this issue Jun 13, 2016 · 1 comment · Fixed by #137
Closed

UrlSource: add proper SSL handling #40

Pentadrago opened this issue Jun 13, 2016 · 1 comment · Fixed by #137
Assignees
@matthiasbalke
Milestone
1.0.0

Comments

@Pentadrago
Copy link
Member

UrlSourceJob ignores SSL certificate validation for now. Preferably it should use an own keystore or the one from the java distribution.
@matthiasbalke
Copy link
Member

matthiasbalke commented Jun 13, 2016 •
edited
Loading

IMO it is enough to provide a toggle to allow unsecure SSL connections. But the default should be false. This way a use can configure an UrlSource to ignore untrusted SSL certificates in case of self signed test certificates.

@matthiasbalke matthiasbalke added this to the 1.0.0 milestone Oct 5, 2016
@matthiasbalke matthiasbalke self-assigned this Oct 20, 2016
@matthiasbalke matthiasbalke mentioned this issue Oct 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthiasbalke matthiasbalke

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

added parameter for urlSource to enable/disable ssl verification matthiasbalke/infiniboard
2 participants
@matthiasbalke @Pentadrago