Feat/#2148-client-Upgrade-to-Next-14 #2149
Conversation
|
Works fine with me. Two things we could improve, but can be done later:
|
Ok yes, I think the images.domains deprecation should be part of this PR since it does concern the Next 14 upgrade. As for the defaultProps it could be worthwhile trying to fix as long as it's showing up on this branch. If the fix is too extensive then I'd definitely like to open a new issue and PR for this. |
…onfig.js with "remotePatterns"
server/package.json
Outdated
| @@ -9,8 +9,8 @@ | |||
| "main": "server.js", | |||
| "scripts": { | |||
| "prebuild": "tsoa spec-and-routes", | |||
| "build": "tsc", | |||
| "dev": "concurrently \"nodemon\" \"nodemon -x tsoa spec-and-routes\"", | |||
| "build": "yarn prebuild && tsc", | |||
There was a problem hiding this comment.
is it useful? It seems that prebuild is called automatically before the build. In this case, tsoa spec-and-routes is runned twice.
But for the dev script I think we should keep it, because the tsoa script is not complete before tsc runs, which causes an error
There was a problem hiding this comment.
Hmm yes I noticed that with yarn v1, the prebuild script isn't called at all when running yarn build.. That's why I called it explicitly in the updated build script. I think the prebuild name is misleading though. On the other hand, when the dist directory is missing, running yarn dev:server was failing because of a race condition between the server and tsoa spec-and-routes. That was the reason for my update here.
yarn install yarn dev:server yarn dev:client # in another terminal for nowFixes #2148