[x/group] Add amino JSON signing support and CLI #220
Conversation
* add remaining tests * removed logs * fixed tests
blushi
requested review from
anilcse,
aaronc,
robert-zaremba,
aleem1314,
amaury1093,
atheeshp and
clevinson
| return nil, err | ||
| } | ||
|
|
||
| err = json.Unmarshal(contents, &members) |
There was a problem hiding this comment.
Given that group.Member only has string subfields, encoding/json works here, but technically it should be clientCtx.JSONMarshaler.UnmarshalJSON, right?
There was a problem hiding this comment.
the thing is that members a just a regular slice, not proto.Message so I guess we might need some Members proto type in this case
There was a problem hiding this comment.
ah yeah. That's annoying about protobuf, if you want an array of something you need to create a struct with an array subfield.
| @@ -0,0 +1,2047 @@ | |||
| package testsuite | |||
There was a problem hiding this comment.
2k lines for a file is becoming hard to navigate. How about splitting into 2 tests files: txs and queries?
| return testutil.WriteToNewTempFile(s.T(), tx).Name() | ||
| } | ||
|
|
||
| func TestIntegrationTestSuite(t *testing.T) { |
There was a problem hiding this comment.
I think it could be useful to add one test using --sign-mode=amino-json, but to make sure the wiring works.
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
closes: #218
closes: #209 (not using ADR 031 approach for amino support)
closes: #197