feat!: add MsgCreatePermanentLockedVestingAccount #42
Conversation
|
I was reviewing regen-network/regen-ledger#220 to try and make sure I covered everything necessary for amino-json signing. I would appreciate a note if I missed anything. @blushi ? |
| @@ -53,6 +53,7 @@ func RegisterInterfaces(registry types.InterfaceRegistry) { | |||
| registry.RegisterImplementations( | |||
| (*sdk.Msg)(nil), | |||
| &MsgCreateVestingAccount{}, | |||
| &MsgCreatePermanentLockedAccount{}, | |||
There was a problem hiding this comment.
I didn't end up having to add MsgCreatePermanentLockedAccount to the RegisterLegacyAminoCodec block up above (line 14). I'm not totally sure why... but I managed to test on my Ledger device with simapp, and I successfully used the CLI for creating & signing new permanent locked accounts.
clevinson
changed the title
clevinson
changed the title
There was a problem hiding this comment.
tACK. Tested with CLI and ledger device and compared with existing create vesting account message and pending create periodic vesting account message.
Should this be documented somewhere? Should we have a running changelog for patches we implement on the fork?
|
I think changeling at minimum is a good idea. Outside of that, personally I think CLI with clear comments / self documenting is probably good enough. I'll add the changelog though. Afaiu, there isn't any expectation that anybody is making use of this feature aside from Regen Foundation, for the purpose of instantiating CSDAO prototypes. |
|
Turns out the error I was receiving when trying to add the Msg type name for see regen-network/regen-ledger#468 for more details. Anyway-- it should all be good now! |
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
|
Nice work, would really like to see this PR in the SDK at some point too! |
|
|
||
| baseAcc, ok := baseAccountI.(*authtypes.BaseAccount) | ||
| if !ok { | ||
| return nil, sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "invalid account type; expected: BaseAccount, got: %T", baseAccountI) |
There was a problem hiding this comment.
This can be sdkerrors.ErrInvalidRequest,Wrapf.... which simplifies the code
…ked-acct-msg feat!: add MsgCreatePermanentLockedVestingAccount
…ked-acct-msg feat!: add MsgCreatePermanentLockedVestingAccount
* Merge pull request #42 from regen-network/clevinson/add-permanent-locked-acct-msg feat!: add MsgCreatePermanentLockedVestingAccount * fix changelog Co-authored-by: Cory <cjlevinson@gmail.com>
ref: regen-network/regen-ledger#188
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: