Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Archive Memory bug #13

Open
savu-a opened this issue Feb 1, 2023 · 0 comments
Open

Upload Archive Memory bug #13

savu-a opened this issue Feb 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@savu-a
Copy link
Collaborator

savu-a commented Feb 1, 2023

Describe the bug
When doing an upload of an archive the RAM that is needed to analyse the archive doesn't get freed after the analysis has finished.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to '/product/[id]/view'
  2. Click on 'Upload'
  3. Choose File (Upload a BOM (CSV, XML) or archive file format (ZIP, TAR, WAR..))
  4. Click 'Upload'
  5. After the Upload process is finished the memory is not freed

Expected behaviour
After the Upload process is finished the memory should be freed

Additional context
The classes for processing an archive were mostly rewritten and optimized. The old implementation contained a few errors. The rewrite has partially improved the memory problems, but not completely.

Also, the problem was that previously several different uploads were mixed together, which is not allowed to happen under any circumstances. I have not tested this again until now to see if this is now fixed.

Uploads of archives should therefore still be treated with caution and after each upload, it is best to restart the container to free up memory.

The uploaded archive still takes up memory space after the upload has been processed. It's less than before but still not good enough.

A deeper analysis of the garbage collector needs to be done.

@savu-a savu-a added the bug Something isn't working label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant