Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG catch system exit call in conda-build #1166

Merged
merged 2 commits into from
Sep 18, 2020
Merged

BUG catch system exit call in conda-build #1166

merged 2 commits into from
Sep 18, 2020

Conversation

beckermr
Copy link
Contributor

This has been killing the bot.

cc @scopatz @isuruf @CJ-Wright

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1166 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
- Coverage   59.13%   59.12%   -0.02%     
==========================================
  Files          58       58              
  Lines        5445     5448       +3     
==========================================
+ Hits         3220     3221       +1     
- Misses       2225     2227       +2     
Impacted Files Coverage Δ
conda_forge_tick/utils.py 59.10% <ø> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5521b...67dd6af. Read the comment docs.

@beckermr
Copy link
Contributor Author

OK let's try it. Happy to back it out and/or fix as needed this evening.

@beckermr beckermr merged commit 97e26b9 into master Sep 18, 2020
@beckermr beckermr deleted the beckermr-patch-4 branch September 18, 2020 21:55
@mariusvniekerk
Copy link
Contributor

Worth a shot. Given that conda / conda build are very much cli tools this is not particularly unexpected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants