Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add R UCRT cleanup mini migrator #2806

Merged
merged 11 commits into from
Jun 29, 2024
Merged

Add R UCRT cleanup mini migrator #2806

merged 11 commits into from
Jun 29, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jun 25, 2024

  • Pydantic model updated or no update needed

@isuruf isuruf marked this pull request as ready for review June 27, 2024 23:34
beckermr
beckermr reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR could definitely use a test.

@beckermr
Copy link
Contributor

pre-commit.ci autofix

beckermr
beckermr approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once you are happy with the PR, merge away!

@isuruf isuruf mentioned this pull request Jun 29, 2024
Merged
5 tasks
@isuruf
Copy link
Member Author

isuruf commented Jun 29, 2024

@bgruening @mfansler, we need to add these changes to conda_r_skeleton_helper too.

@isuruf isuruf merged commit 841ebd1 into regro:master Jun 29, 2024
2 of 3 checks passed
@mbargull
Copy link
Contributor

There appear to be recipes that have the m2w64- packages added verbatim and not via {{ native }}:
https://github.com/conda-forge/r-stringi-feedstock/blob/89e399212d8ac729721523b1415c071d2c16b641/recipe/meta.yaml#L48
https://github.com/regro/cf-scripts/actions/runs/9729117591

But: Those are very few: https://github.com/search?q=org%3Aconda-forge+path%3Arecipe%2Fmeta.yaml+%2F-+m2w64-%2F+%2F-+r-base%2F&type=code
=> we can handle them manually

@mfansler mfansler mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isuruf @beckermr @mbargull