Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to correctly compile intrinsic types #31

Merged
merged 3 commits into from
Aug 26, 2021
Merged

Fix to correctly compile intrinsic types #31

merged 3 commits into from
Aug 26, 2021

Conversation

ChristianMurphy
Copy link
Member

leverage ComponentType to allow for class components as well.

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Avoid inlining intrinsic type.
Use ComponentType to allow for class components.

similar to remarkjs/react-markdown#638

@ChristianMurphy
types: avoid inlining intrinsics at build time
0ff4aae 
leverage ComponentType to allow for class components as well.
@ChristianMurphy ChristianMurphy added the ☂️ area/types This affects typings label Aug 26, 2021
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 26, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@ChristianMurphy ChristianMurphy mentioned this pull request Aug 26, 2021
Draft
14 tasks
wooorm
wooorm reviewed Aug 26, 2021
View reviewed changes
lib/custom-types.ts Outdated Show resolved Hide resolved
lib/custom-types.ts Outdated Show resolved Hide resolved
lib/custom-types.ts Outdated Show resolved Hide resolved
ChristianMurphy
ChristianMurphy commented Aug 26, 2021
View reviewed changes
lib/complex-types.ts Outdated Show resolved Hide resolved
wooorm
wooorm reviewed Aug 26, 2021
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect otherwise!

@ChristianMurphy
Copy link
Member Author

This could probably be considered SemVer patch, because it allows TS to do what JS already could.

@ChristianMurphy ChristianMurphy added the 👶 semver/patch This is a backwards-compatible fix label Aug 26, 2021
@wooorm wooorm changed the title types: avoid inlining intrinsics at build time Fix to correctly compile intrinsic types Aug 26, 2021
@wooorm wooorm merged commit dac20e2 into rehypejs:main Aug 26, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 26, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 26, 2021
@ChristianMurphy ChristianMurphy deleted the leverage-react-intrinsics branch August 26, 2021 14:12
@wooorm
Copy link
Member

wooorm commented Aug 26, 2021

Released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcohaszing remcohaszing remcohaszing approved these changes

@wooorm wooorm wooorm approved these changes

@Murderlon Murderlon Awaiting requested review from Murderlon

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristianMurphy @codecov-commenter @wooorm @remcohaszing